Re: [PATCH v2 1/1] tools/libs/light: fix BAR memory address truncation

["Chen, Jiqian" <Jiqian.Chen@xxxxxxx>]

On 2025/10/22 23:44, Anthony PERARD wrote:
> On Mon, Oct 13, 2025 at 03:45:33PM +0800, Jiqian Chen wrote:
>> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c
>> index 2ea2caeb6624..ae416a162360 100644
>> --- a/tools/libs/light/libxl_pci.c
>> +++ b/tools/libs/light/libxl_pci.c
>> @@ -2040,7 +2041,7 @@ static void pci_remove_detached(libxl__egc *egc,
>>                                                   size, 0);
>>                  if (rc < 0)
>>                      LOGED(ERROR, domid,
>> -                          "xc_domain_ioport_permission error 0x%x/0x%x",
>> +                          "xc_domain_ioport_permission error 
>> %#"PRIx64"/%#"PRIx64,
>>                            start,
>>                            size);
>>              } else {
>> @@ -2050,7 +2051,7 @@ static void pci_remove_detached(libxl__egc *egc,
>>                                                  0);
>>                  if (rc < 0)
>>                      LOGED(ERROR, domid,
>> -                          "xc_domain_iomem_permission error 0x%x/0x%x",
>> +                          "xc_domain_ioport_permission error 
>> %#"PRIx64"/%#"PRIx64,
> 
> Why does this message refer to "xc_domain_ioport_permission" now instead
> of "xc_domain_iomem_permission" ? (I'm guessing overzealous copy/past
> ;-) from the previous error message)
Sorry, will change.

> 
> Cheers,
> 

-- 
Best regards,
Jiqian Chen.