Re: [PATCH 2/4] vtd: Collapse x86 subdirectory

["Teddy Astie" <teddy.astie@xxxxxxxxxx>]

Le 22/10/2025 à 12:13, Andrew Cooper a écrit :
> On 22/10/2025 10:51 am, Teddy Astie wrote:
>> As VT-d only exists on x86, it doesn't make sense to have a x86-specific
>> subdirectory.
>
> VT-d does exist elsewhere.
>
> Xen (via the absence of ia64 support) only implements VT-d on x86.
>
>>   Moreover, now that vtd.c empty (once we moved the deprecated
>> iommu_inclusive_mapping parameter), only ats.c remain which could be moved to
>> the upper directory.
>>
>> Collapse this directory to make the driver structure clearer.
>>
>> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
>> ---
>> Do we care much about iommu_inclusive_mapping ?
>
> What do you mean?  The functionality, yes.  The top-level option option
> that's been listed as deprecated since Xen 4.12 (7 years now), probably not.
>

Yes, I'm speaking about iommu_inclusive_mapping=<boolean> command-line
option (that lived in vtd code) that is actually deprecated and replaced
by dom0-iommu=map-inclusive.

> But if you're going to delete it, it should be in a patch of it's own,
> including editing xen-command-line.pandoc.

I can add one (along with a approriate change in changelog).

>
> ~Andrew



--
Teddy Astie | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech