[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] vtd: Collapse x86 subdirectory


  • To: Teddy Astie <teddy.astie@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 22 Oct 2025 11:13:47 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fX+8kL8hXMd+fXcnSs+8jpvv8rpvGXSdcl7GagP3dsQ=; b=juqyIUmqoUYHVLP4Fnc0MYfsBAnSwxCeBDGUaNUApYY9lZAhd4Jhj6yl15yHxpl7LdFB1Jwn0Xh8m6zFUKxFPRNm8khCuNDUyfsER8wyXfqO3CPMRKpxBZbtZg30NqAdDYyl1IeJsu14qLnK/PXMuEsqKK6SoXP0Jab3z4caexU8OxZSQI0BGdd1D9S8HVjgDwjvcUOm+u0HT11llFmXO/I1z81LQQAFk/ayVU6esayWFUEarp6XrcDjARahCo23OvqWX6XtMh+JnYX2D2Kr7wkSLI3cGMlqhB0buMJmiwOS6SiokdSNRy0LFDwaW1W3Sxu7cIjeZ4PMQEQaK8F+XA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fc+i5COOxaLkJOHHB+gWyGBley7r56SsbIbQa0g2oBpzQZCHXLqkOI6rnxVWvNGTsESYNrIIVX9d8nI+SmfUrSZj2Ha7SEuIe3HawpzMswJ8Qn44/l65IVHIj1UrOJctOLA1Tg/58v2PVBYiJ2S1GG/g0P/QBTlHVz2srkm2Skw1pa+VkUHmu87J0ynX4IqyF0ZcakAtjHUrm9dhg8kWMivrRqk1WBH06Q+5+TeHxAXhCo7eAhGZglcq9Cdb9gzNht/lMSV5QvqXEeXnHwAlabJsvNjbjjDGr1p3Kwy9LbhbPp9cJTYd94wzZA+DUKkOqvXQBBOW/55qIvewNjN1Hg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 22 Oct 2025 10:14:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/10/2025 10:51 am, Teddy Astie wrote:
> As VT-d only exists on x86, it doesn't make sense to have a x86-specific
> subdirectory.

VT-d does exist elsewhere.

Xen (via the absence of ia64 support) only implements VT-d on x86.

>  Moreover, now that vtd.c empty (once we moved the deprecated
> iommu_inclusive_mapping parameter), only ats.c remain which could be moved to
> the upper directory.
>
> Collapse this directory to make the driver structure clearer.
>
> Signed-off-by: Teddy Astie <teddy.astie@xxxxxxxxxx>
> ---
> Do we care much about iommu_inclusive_mapping ?

What do you mean?  The functionality, yes.  The top-level option option
that's been listed as deprecated since Xen 4.12 (7 years now), probably not.

But if you're going to delete it, it should be in a patch of it's own,
including editing xen-command-line.pandoc.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.