[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] coverage: add missing include for macro


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: "Lira, Victor M" <victorm.lira@xxxxxxx>
  • Date: Wed, 10 Sep 2025 17:33:01 -0700
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=citrix.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GDWJSEcTVjc0wJZaqkRixzXwBrasAZEKCM01Inh6H/s=; b=fRpo6UcGNQxfZYxZQ0Zt/OwzW8amoDJikVqUIjVkw8fB6zZuTCISMTA6fYi8Ktbkst6TOUFTmQoP5EVW4u/eHs+We8F7VO47LQDYLYDEGRfvQ5nspLlwBvLlUJIYWk3PdpRrYCqIFerK7MtvlSywaI5LJH6yrGPCrJrtcJ1CbRjKGU2+BqhzVFEloUa7/jcYIfKYNw+7EjABMMNpigiyANcI4av8zUbQ69rHnuf4b2I++pEtxaI3YAdda9AsGyjTeGF26KleTIrzh5zZ1HdS7Fk/ou6x04ISJhI2azGuttEK6hwX4wkJBI6u+6VMswYkypfrm04H5fvjIHMY+fIVFg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qaFwrGm744H4dNCqvZj5zokUiDPw65eUyPRTWxTRmWDfN1D2IfuSBdgj+fDImotU72fIT761JzroBa9zpK681ib7Cmimd06h/PeYckUWX96dhIXEID8RJyLiJs4NN4LMF9nvcIqdkcLUd9E0i9A8uhayft9wGrusn2ADRz7ZvXHtHOeowJJRCFksuW9W6oongkDJ68enGKfFYaZdkaIMLSDhmOPNRkcsgyDy3TOpkddBGw7EsSlTjq/x4LV6SeztD2lpdI4TN/jgX9FBrjcnU92tPSI1MntCeONrHvwTaYoyDDYkIz/TA+RDMLNt6t34gWXf/XxgqWtRcpsP8tjVIA==
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Thu, 11 Sep 2025 00:33:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 9/10/2025 4:47 PM, Andrew Cooper wrote:
@@ -5,6 +5,7 @@
  #include <public/sysctl.h>
  int sysctl_cov_op(struct xen_sysctl_coverage_op *op);
  #else
+#include <xen/errno.h>
  static inline int sysctl_cov_op(void *unused)
  {
      return -EOPNOTSUPP;
... this is starting to get overly busy to read and could do with some
extra lines around the primary #ifdef CONFIG_COVERAGE / #else / #endif.

Happy to fix up on commit.
OK, its fine by me.


Victor



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.