[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1] coverage: add missing include for macro
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: <victorm.lira@xxxxxxx>
- Date: Wed, 10 Sep 2025 16:40:02 -0700
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ywd4+98JNVWn5LlquwViQkCbOtL4x1Nk8xfenPNoMXs=; b=WzckdDXhbPy/horpvlCWctXE04sL50QB0kAlhCav4D+Urqz3qOV6KIARTi+nnxTzow/AaT+tglg6Yukt+vl67x+Vtdh+tfKdwd3RIBJXnVxlbZnwvAUfKW8FrRLJaray9zwaa7PEEwLU7NtBq1ObN6a3DTw3Sn/j3xlgW8HxV/crGvfgD3J+QWfBP+SXL0TAGvXRdP+AvB/rRPjxREjiTPmopK1QqZZlfNM7JHpl6riA8Ja5jxeu2JsVtWXVQtD39T/UGkuOGVhYFu7cfmBzzLpHtTfjyf5onKG3pTVAQOYxmvxe91VShfgGOt8JNsZIcEpns3mzXREwcVxM6bepzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vq87AHm+TLSXR6RTPQRcOuuNQydcXgID9TXIKtukqlrLr1SOEkITG0URqclAJ2zn48g1jezvx8G+4XzGo9uaaig0fUT2IgW7IAqCxsKsQR/zBvFTXWvcLf0lfopjUs4hbtEp7d0sAmmBeUTAXKxOrh6ufY2JAxkJraJd+OL33C2NTkfhN8n7uvSOOQswsR+pHoyP/zMedTa24BtSrAjFuHdeHJMC9+L06U/eN+STjWlU/skiAcXJ7tcuKvkCCTiL9T7my3kKGCtLwbPssDf15sPVVOzatE3td5igSoxQwrG2KMk8egJcKrFMt9SieNkjCmWRfSFdfv5CbVmTlDJ2WA==
- Cc: Victor Lira <victorm.lira@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Julien Grall" <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Wed, 10 Sep 2025 23:40:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
From: Victor Lira <victorm.lira@xxxxxxx>
The missing include prevents it from compiling when CONFIG_COVERAGE is not set
and the header is included in a file that has not already included errno.h,
causing EOPNOTSUPP to be undeclared.
Add the missing include.
Signed-off-by: Victor Lira <victorm.lira@xxxxxxx>
---
example of the problem:
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index 7ad870e382c..4d27f16e8ef 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -10,6 +10,7 @@
#include <xen/bootinfo.h>
#include <xen/compile.h>
+#include <xen/coverage.h>
#include <xen/device_tree.h>
#include <xen/dom0less-build.h>
#include <xen/domain_page.h>
---
In file included from arch/arm/setup.c:13:
./include/xen/coverage.h: In function 'sysctl_cov_op':
./include/xen/coverage.h:10:13: error: 'EOPNOTSUPP' undeclared (first use
in this function)
10 | return -EOPNOTSUPP;
---
xen/include/xen/coverage.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/include/xen/coverage.h b/xen/include/xen/coverage.h
index ba5fb67947..28506c239b 100644
--- a/xen/include/xen/coverage.h
+++ b/xen/include/xen/coverage.h
@@ -5,6 +5,7 @@
#include <public/sysctl.h>
int sysctl_cov_op(struct xen_sysctl_coverage_op *op);
#else
+#include <xen/errno.h>
static inline int sysctl_cov_op(void *unused)
{
return -EOPNOTSUPP;
--
2.50.GIT
|
