[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2] x86: Fix AMD_SVM and INTEL_VMX dependency
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Tue, 2 Sep 2025 09:40:48 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PypRkw6gaVGzZSLokYgt0zMAdxYAKVqWEWSnmDuouAI=; b=elRvcw5GtNQZRkOKSV0JUgFGG1hpN3AkJ9zT2f+3MOuBLNP/xOfNfRJy3Xd7A29TNprNSX7nI9qe6tIAh1vAf2R569aIJtjemL68HIcZtNWPFabsL0CuiCQ6Ex/d8VAm/ENdZCYeJviwm6qk0Eft0jAtjMuCOirQCioQO9xQ3AMLKbqlV0VC8g7AWpm8vFplnlReIj2pYHmOL9gyYYDwj+hjkoOjlP+g1Tqdvs7Zxc76nnXvYt6Cq0GPvPQgS1AL4esTHogGZFoyiFSjlRnO7C2XLzvuT18EmOzkC8Xv9RKEOgevay61/OBcftFMOBTmrboGT+cdJE8qJ9u10gQVCg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SGMIEeRLYO/GHDqLPMVvbJuD1RB+7Ytxh7d9kstaQSU0bzyenNy2vf7HnzrvebJYpVUS9Wp1SFijvYzO+cdGb/7Hj2kYYpzsKq0a2ZyRiptoEN/3Iu1SXw9h/1jz1n345fMBg53iXz2Jzfi+y4lPqS4aUVBHcjJTDLH4en1IYIpaepcc37FPpNnfP5UecVy14qn8TaQzE5xssK2PubX87bYJ18sxhuqaF9xXZyagliVAJWpJAscfJ3VCOJczGTiSnisveaPSOugcagspX7oUns4heCjy5/Ug0bP/NouQ+YSGElHNGeBjpd8frLDU+wL/YozbH2/a1X9yuvR22Efyxg==
- Cc: Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 02 Sep 2025 07:41:23 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Commit e3ed540f2e9f was meant to make AMD_SVM dependent on AMD and
INTEL_VMX on INTEL. This dependency was reflected using 'if' next to a
prompt which is incorrect as it that deals only with the visibility of the
given Kconfig option. This makes it impossible to e.g. disable INTEL_VMX
when INTEL is disabled (option is hidden). Fix it while keeping the
possibility of e.g. enabling INTEL_VMX when INTEL is disabled.
Fixes: e3ed540f2e9f ("x86/hvm: add HVM-specific Kconfig")
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
Changes in v2:
- change default instead (Jan)
---
xen/arch/x86/hvm/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/xen/arch/x86/hvm/Kconfig b/xen/arch/x86/hvm/Kconfig
index b903764bda0d..5cb9f2904255 100644
--- a/xen/arch/x86/hvm/Kconfig
+++ b/xen/arch/x86/hvm/Kconfig
@@ -16,8 +16,8 @@ menuconfig HVM
if HVM
config AMD_SVM
- bool "AMD-V" if AMD && EXPERT
- default y
+ bool "AMD-V" if EXPERT
+ default AMD
help
Enables virtual machine extensions on platforms that implement the
AMD Virtualization Technology (AMD-V).
@@ -25,8 +25,8 @@ config AMD_SVM
If in doubt, say Y.
config INTEL_VMX
- bool "Intel VT-x" if INTEL && EXPERT
- default y
+ bool "Intel VT-x" if EXPERT
+ default INTEL
select ARCH_VCPU_IOREQ_COMPLETION
help
Enables virtual machine extensions on platforms that implement the
--
2.43.0
|