[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/public: arch-arm: Drop XEN_DMOP_get_ioreq_server_info from supported
- To: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Tue, 2 Sep 2025 09:27:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=epam.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EI/oTIsEH+yF+vdp5hZ8znu5avii+Lx+745u0RHTIhI=; b=zHpC1WboxZzy3HCPylSie6wH9Wer7la2UbDO9M18ncTglS1k/VyCDSAfLymGQ9meX8FQ7kI09X/RBCKGl5Y1ad/7gFZt0hf1uPRWtyuwmEJwDy9KQv+zmzSt9ZBYTbj5v641h1TWQEQJNUjrLmiFHFh8tpdwIOQa4X/emMK8Ksk7nlIzJlBrk4YFeHLt4d2ISKVmWNbWaB0N5Vznm6hWXAv+w+Hkn+b7k2KQfaXC6NKIzu8G9fKLRiM1Vv/szkxUYiyHz5nQ9CHh6cM+DPEJcXVqHMhQatOH77yulEB2RHUe5x38W+C5RZSCiCe0C1umwG1dER7+bXv9v5wWD5RwKQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bs4QUvXR/hMjPbJGs7OjAKnY4LCyBzrbtZHO1ir4hNPBGr860gHQBHMhKmTXo8nty6b3bMrx4+iLihdQxqV2ib29C/6I3YsGL5n1omiQnJ4wKJhwkuRL2ydjU6/VhlD7V+Sx/g1+IpkpO1/i8ZqdRC9yzYPDRgXcxpOQtXpZNX9F0LTrIHbCZ7AMJJgxxAyx+sio8Flqfpe1/A0QNutdeVZuPIeExHzMvpDCh/BPYZt49r+x3k+CqnRVZitu/i3n7dbVemzZPdaI4lGqjpz/IGevLaJJ1gUEJk1D7j9q+8ZSfF0R4HxbDQPmZFkKv+Qv1GQTD27FmZY/wUElAXgBTQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 02 Sep 2025 07:27:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01/09/2025 14:58, Oleksandr Tyshchenko wrote:
> The said sub-op is not supported on Arm64, since it:
> - does not support the buffered emulation (so bufioreq_port/bufioreq_gfn
> cannot be returned), please refer to ioreq_server_create()
> - does not support "legacy" mechanism of mapping IOREQ Server
> magic pages (so ioreq_gfn/bufioreq_gfn cannot be returned), please
> refer to arch_ioreq_server_map_pages(). On Arm64, only the Acquire
> Resource infrastructure is used to query and map the IOREQ Server pages.
These points are valid. However, I don't understand why you mention Arm64 only.
What about Arm32? It's the same here.>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> ---
> xen/include/public/arch-arm.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index e2412a1747..023cc2f468 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -130,7 +130,6 @@
> * HYPERVISOR_dm_op
> * Exactly these sub-operations are supported:
> * * XEN_DMOP_create_ioreq_server
> - * * XEN_DMOP_get_ioreq_server_info
> * * XEN_DMOP_map_io_range_to_ioreq_server
> * * XEN_DMOP_unmap_io_range_from_ioreq_server
> * * XEN_DMOP_set_ioreq_server_state
This list is kept in sync with the op_size array in xen/arch/arm/dm.c.
I think we should drop this op from there, not only from the comment listing
supported ops.
~Michal
|
