[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XEN PATCH 2/3] xen/macros: Drop alternative definition of BUILD_BUG_ON(_ZERO)? for old GCC


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: nicola.vetrini@xxxxxxxxx
  • Date: Wed, 13 Aug 2025 21:12:49 +0200
  • Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214
  • Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1755112438; h=From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=X8Z/Iy3vEL05qlHR3iwBDCDEqtsnD159/f7F2D0+DUs=; b=i6ZvIGiNHShaLfpmOXmHMrPxxxR11TeZd46h0tCg6aSV3BEFcnS/37r5blbbkCMdB5cK kUIAusgTbkFlUxn8+9TMbi4o1rFFYBcolN8i6NxwQv0quIyXKVrgMtH7xT7sqLg67eOYw E0MD7HUOYJFdjahoz4rqevsfk30GfVuaz3KN0nRN/IeRUEUCRZcHtNd6cX93oWI5Mim0E 2UH9Ze4Pl2Ifvn6/mVsRN8Bq1bnP3jlo/ieZI3hD5xx1fQvQqV6rlfZ/w/ajclj2V4Y5w RW+147oYe+gI/jhIaRiwl27yTBTyaPmnifjKyYMdRXnS7JpovXrG914zVHRlz1nDQ0IwH w5mMLpFa3NTMo9xV0BwHXftIglaIV7nFosC5AI4C7JAXYVKbE58Huk8nKplLHmPHDiGm9 ok8v6LPqP3BwOiwprBVysBTiznh3/GoG9YR6FlUi4mAJ3jqrt2zLz/BL7l/64ksPzi3hU pz+IYNVnX40ESwbqeR2VztlC03+8fgVY+jwxq6TlKn9tHlSMpnc8VPx+3zyeY8AL3c2T1 owe1So80mE4OR3zsIAIfDF2ROINyEW6YaoPtBlIj5kCNi9pHFKBcGxvwI54z7vL6ykKJ2 MOWo2qKIycsZiAMt6BzvpotWbXU+6ZZM2CGUAqohbaWbIj0dT9R8NkkXhXSdvx8=
  • Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1755112438; b=xYpRKG0Du5MG9elu+KVdUZcS71KNziGvjzX5TOOeQ+qOXLyxBmPpC9DnnSz1/7OCsSW/ ZlUeUUOtolTiZ2w8hEICuhjhyyYI/mOslVdko3ZAk6D59Re7OCCu7u7FXyV/uSUjIaMk0 gVVdPVu+X6QHkZvbZJLZIkayAqxVoadGYlpw6cBqb5UUjdOtj+cqTvjtfwC+9nplbShfs 2brMdWfUzHNBOhWWbFJCTNq9+k+cwrk+5DS7pNZHE1rGdMyG7EnYV6kTqgQtszyr03Fz4 7k6mHip8BS2AjgLrkkuQjnMKg+aOVslkHxsMeDjA4YNkSx37XQByL/7vGFf4gzvddIrHL WaDP0FCDrw982v718GixZIRmsDMhU1yZEGQx6emuEtQS7069Prc1izkdD0G66H0o/nx/d +GBs7qh8+8bb4U3YxUxV8CXECDBKptqazVgc1klt3NZfhqv9E3D3rECD6J8PWulS8fUNp cntKESnJY3M16Gy+IhuSXXz++g0WaWXJH7MT1ijGm8YyKfjxsEMJZJxSGA09h0jPzkQkc as31F5Gl2Zc5WdRTAr+RdDUuUWg4S4LKV5NLxjJSv+7eOWUrNK7M2Sal5648AGQ0+k8WK RQ2bOaNic8tIeCreo9mA1teB8GADkuZqHnZqHYMts64Peug0MVsfSuUfpi24V7I=
  • Authentication-results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214
  • Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 13 Aug 2025 19:14:02 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

From: Nicola Vetrini <nicola.vetrini@xxxxxxxxx>

The toolchain baseline for GCC is 5.1, which supports _Static_assert
in c99 mode

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxx>
---
Mentioned in https://gitlab.com/xen-project/xen/-/issues/201
---
 xen/include/xen/macros.h | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/xen/include/xen/macros.h b/xen/include/xen/macros.h
index cd528fbdb127..f9ccde86fb23 100644
--- a/xen/include/xen/macros.h
+++ b/xen/include/xen/macros.h
@@ -40,9 +40,6 @@
 
 #ifndef __ASSEMBLY__
 
-/* All clang versions supported by Xen have _Static_assert. */
-#if defined(__clang__) || \
-    (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ >= 6))
 /* Force a compilation error if condition is true */
 #define BUILD_BUG_ON(cond) ({ _Static_assert(!(cond), "!(" #cond ")"); })
 
@@ -54,11 +51,6 @@
  */
 #define BUILD_BUG_ON_ZERO(cond) \
     (sizeof(struct { char c; _Static_assert(!(cond), "!(" #cond ")"); }) & 0)
-#else
-#define BUILD_BUG_ON_ZERO(cond) \
-    (sizeof(struct { unsigned u : !(cond); }) & 0)
-#define BUILD_BUG_ON(cond) ((void)BUILD_BUG_ON_ZERO(cond))
-#endif
 
 /*
  * Force a compilation error.  This is for code which, in the normal case,
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.