[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XEN PATCH 1/3] xen/compiler: drop alternative unreachable() definition for older GCC


  • To: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: nicola.vetrini@xxxxxxxxx
  • Date: Wed, 13 Aug 2025 21:12:48 +0200
  • Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214
  • Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1755112431; h=From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=VOKEf9dD+zgMtMXQ5hikRxtG6VewsOUliCA+rvTuy60=; b=kPGNecuzv54LVaDjZZTgvZLLDFeW6GmBzKh9OEc2AMuOqUbItm34KJtOCCf8h+pYEsSw uGZYJeQJDyUy0nMojOcfx42EIw2Guzm1TNC3NKSrU2Gy3yvDVIvmAPo+mAD6pqKS/0Cxb yDvD6dgwvzfi1IPmaYHDLrqYID4XLH+xbiSuJw6MkEnkvDCCUwX1Mz1Ydrq3etsSUqv4k isvxyDljWTCC9nIL/KefZGFVwb8NEe7UKi3zxJlLZLD4OrUtKC/9CBxuHGBiGbep3l76u DY+dBcNRfb1wIU3AGa9XcwZXexZcgEVQRrqFss2+ZFYUvtZ9t3fimpmfqTasZU99OV9Tq 7/Ag22e77Fq3yO+ts3cFkPBDSAg6TvaJLGd+1/+GQn7EI2eYxQQDVmeXI+QsIw5FEdqIx EKWlfgd6qVksSEHbmzAzZFcDEdaTNurVac72udjbJaIb4AuDSc+WK8KYbPAR/Z4kx95uG nocdmpb177yC5oF+jwyDyHNC4px3n3viwADQVQZdZyOdMDoSjGQ/vklNfaFuUc1qbjbsu Cs6I6e7Mo20i1MvtUAvdt25C//Z7tr7kOSYzXbtXMXaA9SnBcviWdk+7D9/MVjpfN88aG AR+5E57+o7hKD2DbysKWHLXb5SfYhgbRV5CYFPpejCuV7voHOnCebkeI+mkc01E=
  • Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1755112431; b=WUSxfd6QKmXCEYL1lgv5Kf+5yGRKv/zdL9MdCPOIs1qRRMinh+Y7Gc48Cse+T3QDPWOi 2nLy+tnZ/ur/E8qfecWkOVnWqHc3VyyTk6wiNhiWqlHOhmNmlsZ3e2ctkrOvX6O32n6Hb Kp1oAde6rdGjjL57yO087x/8b/XVkAYjTgZQFdcx/WXi+poXrkMfaLFdwBfVpm3dbnHwh 6ytm1iKTqUD6KlR4RDuy+fQp5VSYIrSeBaG6tdsEn4wWhAgU4/PdbTM1A91hT4vuFX8Gv uu/AqmFmlBE8CUMWNZNzHSlNRf8bbFTIldkl/QfWmLvozJ+S6AU5+3eI8Bo1gApW/G7rL ZKCzjnwHwwqnJtMgUaAzLmBerwgqRKZopJf4V1VLVRL5q7dsj7IczMA2YdIj+XxKuKmOk yRLxZYbba/GWUwU00j5QY4UlSy+7YC59kpDKVPmKHePF4hkRZfaFZUBoK7vjSN1GjKjd0 oxafUra7G4kzrGn5aK17sLe7J2GD9SE5b5jzdTVFgWXJsLw31+Q4WKYHc0xI9aX4dlS5i QFnjE56UDUwEzI1XoK8jgw2K8HHozBfABrWdhm/OklJTWIzF7V1VI3yUSnX/Qiyy+Sign h+FbofBVsM4FSsMcP62I41aYQLfcaxfBTYYW+m2cZ+xJ+7uVaXpVZFhXGS547DI=
  • Authentication-results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214
  • Cc: Nicola Vetrini <nicola.vetrini@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 13 Aug 2025 19:14:01 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

From: Nicola Vetrini <nicola.vetrini@xxxxxxxxx>

The GCC baseline version is 5.1, which supports __builtin_unreachable(),
therefore the alternative definition can be dropped

Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxx>
---
Mentioned in https://gitlab.com/xen-project/xen/-/issues/201
---
 xen/include/xen/compiler.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/xen/include/xen/compiler.h b/xen/include/xen/compiler.h
index 735c844d2d15..88bf26bc5109 100644
--- a/xen/include/xen/compiler.h
+++ b/xen/include/xen/compiler.h
@@ -47,11 +47,7 @@
 # define cf_check
 #endif
 
-#if (!defined(__clang__) && (__GNUC__ == 4) && (__GNUC_MINOR__ < 5))
-#define unreachable() do {} while (1)
-#else
 #define unreachable() __builtin_unreachable()
-#endif
 
 /*
  * Compilers estimate the size of an asm() block for inlining purposes.
-- 
2.43.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.