[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] arm/mpu: Implement early_fdt_map support in MPU systems
- To: Hari Limaye <Hari.Limaye@xxxxxxx>
- From: "Orzel, Michal" <michal.orzel@xxxxxxx>
- Date: Thu, 17 Jul 2025 15:00:53 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYRI7abob4xdloZ0InzDLV311A+vtl6Ssa8Hm9vrwD0=; b=nbcIZ7DncVVXPld6O7+4vpN+5KGYGnX5cfnB+0WWrPCCewRsMvfjzG3Sf7lRDuZlvHfahQL5x4xRyjw6ki16LZRsk5qYr1EiIYwVRwOoXkdYvoCDqhEX3G6XgvCTIzaMT78sVZwli/kl8wG1wTE//IgMG/UDZ/xZXGcg4MlSS+nuO5T0UgusQVdj72rAwumebdKfTLRVdOycBrpmQqjnrP6tzAQ5z96MkXQDKMugImOZ36Pre1Fb1YcQIJhFNp8Pf0yFlW3Rwfp7mcSjF2kNm/z9hXDTSvIf4gaK3VbH0fVq34qyqBaaxzUADKjFyk250JryOolshtvKlw5X2CGnKA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sYTRrRqXpugXSw6RRkipjJIW6vkJIf5mz+SLPAOO+rMpyQ/bvFMY8bfJlhUIB205WoTuxeQetGojDFCia+4OT+XlSup/qzB4bzTQ1rC5vkb7j28Kl2JAdf5H6MiEsaBtM+QLUcPlxfGN5s4V4NxOQH2bmr/N9iT1Pox2slVDjNESO3YjLelApUJoWVCNSc8YlNV0oGQtTRwEInBk/lr5fzezrklftm6sx8YmzDhDsAaxt+Uk+M3hNPYngLvQE8iaJxBdKqGHdBBVoGdl23dfBCDBoQkHqmMdIIkCDUJtWG3X5ye/f+A6aDSs0JnHd/7pplOdHRFnIRiLbU+FXIS5sg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- Delivery-date: Thu, 17 Jul 2025 13:01:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17/07/2025 14:58, Hari Limaye wrote:
> Hi Michal,
>
>> On 17 Jul 2025, at 13:54, Orzel, Michal <michal.orzel@xxxxxxx> wrote:
>>> + /*
>>> + * DTB starting at a different address has been mapped, so destroy this
>>> + * before continuing.
>> I don't understand this scenario. Can you describe it in more details?
>> I know that early_fdt_map will be called twice. First time, mapped_fdt_base
>> ==
>> INVALID_PADDR and second time, mapped_fdt_base == fdt_paddr. What's the other
>> option?
>>
>> ~Michal
>>
>
> This was intended as more of a sanity check than a situation that was
> expected to occur. Maybe you think it makes more sense to remove this and
> just add an assert that `mapped_fdt_base == INVALID_PADDR` here?
Yes, assert would be much better here. I can't think of a scenario, where
fdt_paddr would differ depending on the call.
~Michal
|
