[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] arm/mpu: Implement early_fdt_map support in MPU systems
- To: "Orzel, Michal" <michal.orzel@xxxxxxx>
- From: Hari Limaye <Hari.Limaye@xxxxxxx>
- Date: Thu, 17 Jul 2025 12:58:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=amd.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwQI9/ttfLDx3YEc9WG+tqj2pQMpzqXpN4Yxr7Ngatw=; b=wFO0EyjAMmBwqM5GPtMz4WLjjEQ11jR86tIITcHT4O7iV+c8RP2bb9Ui0Y1w8skWgrswFigNKz8uDKHGiSQiawdvmD0EMZXRvQ3LOc7gMznraDvMph3XJwDdHBZOUgkoQjUkV4ZIJVe9RFbtYjUmyu32rERrHmdrYa5f+zbST6p2WjYJdJgaBndZnoc18zAKdmu9sXR3RLZO8I/TTGTvox0feOSfpIRBPMr13mlGBNCI5t0kJ1Tjs3xc9Tg0iI3ocjYhyWCFx8I2QkcOVg/zYoqYKr3FBmPqIFSQUa3d3/Jk90zyZKkfd4y1n7kJAn0tdBwY7gcoeXCTmPB/qfxTvQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwQI9/ttfLDx3YEc9WG+tqj2pQMpzqXpN4Yxr7Ngatw=; b=RpBni8hl05BpWSAYzC3qwE4vl5L4IF0ZJmhtB/BThH5cw9uaghlN0F85qwuHQ5Ud2vjOvjJjjUk45fm/e/TsPwqHs4GehOpN9AISAmNZ2Wm5HXu2E8Qz4Z6uzRwzpvYDkc/YOqnp4U0FDT0DFMt1SHcAd5uI87Jpq4lVkfmMr7MXmSOIQn+RNSNqTLPDXRhKX7ySG6lwknERYe3R+kWsJwx7k8dXITjWRL+gUjcZaYx4eC4caQir+FJZFYr+HF41RzIuO8tYMHxrdSMgAIIWxgRWm3UHM6EWNRGtW7G+GtcyZ9rNL8XolvlbB9ht2rVXi68Ig6ReuE+C4YOAamGn6Q==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=Nh+1tOIzQHRR67vr+bgZK2KdjmTAP5HqYzv9TGgR7KTbtZDe+/zCZaw1ZeJIfF/Zn7IxdgKMkvVftaFmjLHNK2zR9IPBvTEsfWa3s7OrAUHrZ9jwpJRu0bz/4/GJSfOL+Bt7MNbj6pnhh7LUSN3Ox78BoIi0mQ2bMZcgckCo4OtXW4YcvuLE4Whr0HOG2EhkdbCVr+GmCefPdIC4Ehq8JJnj/6oG95Fx7q5L4E6kJTQ1ksAqYjcKgBkmnzPwhWit1sGrGOIlrRAmcky+zW62xm1CqY8uraJHc+QJuc1+8koxC+q5lltxjl5oH29xpPu6VLZL0bkMcbtiDfWUNuTgUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QEBxLjdiGOXmhb0yzkMvNVRRqUWX1l5oEoM3xWW88wZJCB0feFr7ws1W7waupVjgvIvNRkXdnfrCofo5yaWgbcMp2aUHiIeSM5Z1K9N/EHtKNgKCrGAs9+Au7FAjFp0CKrYCDsulFsCbU2clm8E70/Y49zBXvxxOStieZZMwbj1FrWXQ7xuVk7gKJDK0ltgHCEd108hTdyykCZDlUTtX++0On7WvGQvq1kUuczWv0heLK6GVB6gyHdSX5SOeta91F62ZVkcyd1xVEXi+Ud4/Y5wzxmjB0D5/hlwr5YgTP58YZRffni/JLu7isznO+k2AvWnqj4ZyEtf5oeWLIdiUew==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
- Delivery-date: Thu, 17 Jul 2025 12:59:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHb9xn3UHtrAGk0JkOM2kT/U4VvKrQ2RsWA
- Thread-topic: [PATCH v3 5/6] arm/mpu: Implement early_fdt_map support in MPU systems
Hi Michal,
> On 17 Jul 2025, at 13:54, Orzel, Michal <michal.orzel@xxxxxxx> wrote:
>> + /*
>> + * DTB starting at a different address has been mapped, so destroy this
>> + * before continuing.
> I don't understand this scenario. Can you describe it in more details?
> I know that early_fdt_map will be called twice. First time, mapped_fdt_base ==
> INVALID_PADDR and second time, mapped_fdt_base == fdt_paddr. What's the other
> option?
>
> ~Michal
>
This was intended as more of a sanity check than a situation that was expected
to occur. Maybe you think it makes more sense to remove this and just add an
assert that `mapped_fdt_base == INVALID_PADDR` here?
Cheers,
Hari
|
