[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 07/11] vpci: Hide extended capability when it fails to initialize
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Thu, 8 May 2025 09:16:49 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+h2FORUlvcPIlretBNSWEat6brs4D4xB3UI9dgNI70c=; b=IHGDG1axrLyiEmMthb4ucj+3nAWJsx1yCL6Hr09Ri2y+VEwmHcBuzTr/HG+Zz3e2sjO6tsmObIJr93d7LuAcQEB8fnYDngmun/GWWhb+Xij6pMEWjcfgWHlPPVMefcjf1VB9SVQjzGq2D9x9GQlilGAXucz3ltPE3hNRVnpgU3EiPL5l8r8K7Ra5k03hv3MBAcj206B2nO6UFGOUD7Dg96oHjoCgVBlUO1A7Qe6vKYkro2TZzlXsWs0UUyxTqMRgFTY0dSS+byqNM/okVBKqbqgxTFxO1nTRc7BxUqPlGJgcWsIu3UE6WEepNPtBMcQBVA/HPp9jZOYaObFUu7BIVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HmpHCqE5HWReDcnCubkbsV1HVjJl1ux2vRRn0/osbJ0k45MmtDzhyCCJagEGwz2437HBw+4wO+j33Lx9utPlmsDImG5bL0A6XtKh3OhFENmC5G2mL58Q6Drs82FLLT1tf5/eEdSDJJWKVNXdAFFGGNNmbYvPoh7hnvqgDr8MjgGyROOlyFFhKb4zI/9/DXg9hpWRmv4DdscBCKaP1LV377pteBAEA4RAy7JL0NKuFHBmTITIB5oZnydbn2WL38Em/hpNUJDyljHqceTSnbedCO4v7xX5GPwMxqhX+voGLKfQoMh6/Mwqa25xcEd+pUb+qu1D0e7IEZVCptqRo4870Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: "Huang, Ray" <Ray.Huang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Thu, 08 May 2025 09:17:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHbsoVd9OkTHNIeNk69huFsDqzHMLOv3AoAgBk3cgA=
- Thread-topic: [PATCH v3 07/11] vpci: Hide extended capability when it fails to initialize
On 2025/4/23 00:06, Jan Beulich wrote:
> On 21.04.2025 08:18, Jiqian Chen wrote:
>> --- a/xen/include/xen/pci_regs.h
>> +++ b/xen/include/xen/pci_regs.h
>> @@ -449,6 +449,7 @@
>> #define PCI_EXT_CAP_ID(header) ((header) & 0x0000ffff)
>> #define PCI_EXT_CAP_VER(header) (((header) >> 16) & 0xf)
>> #define PCI_EXT_CAP_NEXT(header) (((header) >> 20) & 0xffc)
>> +#define PCI_EXT_CAP_NEXT_MASK 0xFFC00000U
>
> To avoid introducing redundancy, imo this addition calls for
>
> #define PCI_EXT_CAP_NEXT(header) MASK_EXTR(header, PCI_EXT_CAP_NEXT_MASK)
When I tested this locally, I encountered errors: every next position address
loss two bits zero.
The next register has 12 bits, according to PCI spec, the bottom two bits are
reserved zero,
so "#define PCI_EXT_CAP_NEXT_MASK 0xFFC00000U" is fine,
but if change this "#define PCI_EXT_CAP_NEXT(header) MASK_EXTR(header,
PCI_EXT_CAP_NEXT_MASK)",
I need to change PCI_EXT_CAP_NEXT_MASK to be 0xFFF00000U, is it fine?
>
> now.
>
> Jan
--
Best regards,
Jiqian Chen.
|
