[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 6/7] arm/mpu: Provide a constructor for pr_t type
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 6 May 2025 13:53:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axEw20NFGkMJnYlA17fJsOAa6P2He4Wmbs7PedWK16Y=; b=kHhFKYdr07KA8S3DElD6ZSMNvll+8Ay6IWwNrvcoik3qUFi6bOSWJ3//bexoV0vw+fKihY6jhq0jyeNbMaAMJ37M/Kkmff50d6YvOLGGykt/LlAbhY5vXkbTukP59Qfom07Nv1LLAjY0Tw8VfGP5gQkpy7lrLim92Hip+8Iv4dmFIZqPm+zvMMiNp1t0c0gn6AA/Pzg3t+FO7jUaNkQ75bpnag4DrtXTYQmLFOLcefH3ouMdm/7igmveSw5J3/I916P460E+feD4wJmPVhZuL7FsApw9ctaHliD2fM0Kx+NYtdh+iI5ML/x/BsAyXFeg0ac3IIBYmN9QU97cf0qw6g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axEw20NFGkMJnYlA17fJsOAa6P2He4Wmbs7PedWK16Y=; b=SQ6Tnu/aG0iWLnSguvEO918+Be/TFZjopOGKNGtk4Za8QEaL5sTe/n1jpXxgSSnv2z+39IaMp9K7SoRqAIsY1oK3OT27gfLYgwIQeAP+7WKTOOIJ52OmZNqO6jOmR2JkJdgxfzQlaVSa2FPrAppEAu+zOlE3t0595FGAO3hK9hnTNbj6gDbDRc2Q0V6By2stmkaC0nf3wy4P7zut9ivc6cQmgq3Io+2Y5itM/ZkQp28275NECarNn/Ytvx6B1pfQrah+T8bbeFXsUNQwQZSNSpFPUzAO27ZQFy6L8wBnye9/aAtUdwHA+s8O9LI7mlMDMSD/F3Gjt2KTXRGcxp/gdw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=GIIvulSqGVjfN0Mpi3khqe7M9wZFDyZGOdkxuhkFp1mqQ6Yy3jyxR0Aw1aNKXbVPxCpdaD8Ry0a5T/2wlALDCTHQYPbtDI1H4xlAFmkIIHlYX3BGVqG7yVILn3676jpLQdMew/l0gh7SQk25pVGwjxdwKWn+j5B2rQhbUlqAYdpcVru1JV2OaI/2NVZ3Sn7v1r0kzLnTlIx5fgyjfSV774qJkR1zpWJeat7ecwhTaiDiSWw5dn1TmfFaWIKu5BHb88UzdqdK/KS4ZxMS/TGgJHITO/6lKK7ZEGmbcYvsf07gtYNjFZLnC0p49yvG1yx2Q0H1heSsK7x/zuHS90iVKQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yD+Wda3vIbQWlvTwfpOpeu1yPMAmXHpKwifGxWDGUqbETcGVTqg/cVCve1vMvkkJW7OYMOqI1ye674mpnu5ln+GwAOXlGhC/JFSgBS+EMT+/9uNOk8No7otsRpDMBYZLMM0lHnAn1TFabV2qtRLP6ZJKDXDs6SAWbZTDtXR9pPSGwZ9tdnzYMmLvpAhvfPvVJEzYxskykeu583ZxGTpWIiSxrlNVRjBk51Vmt81idjZvzYAHb/Vh98/Hhv3cEpr3/Oj9v845E6/s3v9lnw/MYuDpwbiG+FHmAfWwnbsrBHdfbLZ3tlSKeLjsob7mOY/wYGjGZCfqpF4YhG9opi3ERg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "Orzel, Michal" <Michal.Orzel@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 06 May 2025 13:54:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHbuRpqbs0x64sbw06OBQfYV4WEtLPFavYAgAAvLYCAAA+6gIAAAEwA
- Thread-topic: [PATCH v4 6/7] arm/mpu: Provide a constructor for pr_t type
Hi Julien,
> On 6 May 2025, at 14:51, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Luca,
>
> On 06/05/2025 13:56, Luca Fancellu wrote:
>>>> +/*
>>>> + * Creates a pr_t structure describing a protection region.
>>>> + *
>>>> + * @base: base address as base of the protection region.
>>>> + * @limit: exclusive address as limit of the protection region.
>>>> + * @attr: attribute index for the memory type.
>>>> + * @return: pr_t structure describing a protection region.
>>>> + */
>>>> +extern pr_t pr_of_xenaddr(paddr_t base, paddr_t limit, unsigned int
>>>> attr_idx);
>>> here. Please don't use extern in prototypes. It's not needed.
>> I see we have a mixed usage of this in arch/arm and it’s not documented to
>> do otherwise
>> in the code style, in this case I would prefer to be explicit unless it’s a
>> strong objection on your side,
>> let me know.
>
> Old Arm code is using "extern". But new code should avoid it for prototypes.
ok I see, I’ll drop it then.
Cheers,
Luca
|
