[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 2/3] xen/sched: address violation of MISRA C Rule 8.2
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- Date: Mon, 17 Feb 2025 09:31:39 +0100
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; c=relaxed/relaxed; t=1739781099; h=DKIM-Signature:MIME-Version:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID:X-Sender:Organization:Content-Type: Content-Transfer-Encoding; bh=bAnOnOpMg+6gRC1AvDxQLE44E6y/GZB3zVbRQHQbt7o=; b=LROYLFejSM99uk9vW9SKXm6yph21GnewZYigIdZxGYMeDcCThxNSVdFuAATRmiKNmxvX cNwvXJCNwWWpXx/ZO2GrXeEk5ZM6vPB2DRt7a5BPBhKKqzqdj7MLlKHjPO6odU2VHeA5/ OgWdlVdGx+y0OXd0ozyeJw+hIiyHPguvW19QtGkXbLL3frxTRRO431tsKgFaspgLuIoHe 9TTUreprkA3CN+GG3Iu1a/TavGQunKhIJOZGrjGvBkWEoIPree6kclaMRgkkZvpY83NZk V7ycui408/VvNzrTs5bDPWSChdcpKssiqxyfcJ0tWFx5RFowYNPKUVWIgSTyp/bmDZqRX XuJU/fHBmr21C+iKZ0rG421M3iop1jMfppHnwn244lHe8/U/hv/3RksKfl31A1iCX3vwV //W7ZJEpfg6y6ZZvgwbtOHyRtOIjdaR37AWsGCDUPEIP0bDeAzxvYYR6ERndpRz/hCXdX MX++o493XBDuPBdhnJXdcZXjTKrbFU1r4e+qQJbWKfNTtSqgjamR0+lmv/LlqUtmYnSmK Cqjh1ZI+6NREdFSN3iC9cAw4w0I75CAo6dZn6qxsQXRSRNe+NIsHsRVgMMK+9Tvhj0+2A cekyiXPRZs76cL7Y0SrwtenMQ3vVnfq1L4evltXYSIXPZ/TMdMD0AgIBno30wac=
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1739781099; b=2C0LnPYmlWWTd/oWqUpMFCXL10WL9BgJv0zrhYrWgNfY50lKODNkrEFwO3+09zvFhRbB 2ly9mrAmUe0uGY50gUJyiPZtmvQdp/h8w0y+hQEdvIRblsHOzQ75xgks5ZL0H/KdfCAQf TvYzanu+ihDJmQvbqmmxZXS5r9gik9lNYObDrnQhZX0Df8Hs4/tWVk7J1Gz6qLVB6ChT9 VP+FjZnijzSIUM75vLyi/VgGYs/eKM3d5UQpp2YJyl5GgF/Bas4nugh7hGlYYxMbyYwcg WbL2UF2P8ojXFz280l0ct9YsvEaE5y8fNZkTf2up1IURBH8NzhoQ+XL5Uts8RPeCUN312 WYO0cgfkPwK4CkNpvjkKNYL8zolcc0IHvCMzJNcvp2CdPDuMcdMueSr0il44nDvsakRFb hCoRRidPPqY4zqAYVBbWuKQNfyi81fV41RZ4Ar/99OkA45Uh0ubw1dMHboA37wKRrWw71 VfEHRnoU8XhkW4TcQfaQXDt56KCtzu7NxoQciTSXjJszjKjk6Wsy5m9fqfCh39ms2uIyQ pbuJ+5etuwtlAboVyyL9TxYHqIy6hmnQXUP+CGlSClCzr9axkK1BgxoiL0d9cjYUAAosr dCQsaUkex8bG+GawkGhO3FovyOB1UkJ7SNBH+4JYTNLc+UIwCTd6TGAp7ZMoWiE=
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=162.55.131.47
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Dario Faggioli <dfaggioli@xxxxxxxx>, Meng Xu <mengxu@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <gwd@xxxxxxxxxxxxxx>
- Delivery-date: Mon, 17 Feb 2025 08:31:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2025-02-17 08:54, Jan Beulich wrote:
On 15.02.2025 00:04, Stefano Stabellini wrote:
On Fri, 14 Feb 2025, Nicola Vetrini wrote:
Rule 8.2 states: "Function types shall be in prototype form with
named parameters".
The parameter name is missing from the function pointer type
that constitutes the first parameter.
No functional change.
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
This small fix is needed in order to keep the rule clean in the
follow-up patch that changes the Xen configuration under static
analysis.
I wasn't really certain about the right name to give to the
parameter,
so if there are better options I'd be happy to accept them.
---
xen/common/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
This is a specific scheduler you touch, which I think wants expressing
somehow (e.g. via an adjusted prefix) in the patch subject.
Ok. I think it should be "xen/rt" then.
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -500,7 +500,7 @@ deadline_queue_remove(struct list_head *queue,
struct list_head *elem)
}
static inline bool
-deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *),
+deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head
*q_iter),
I think it should be "elem" instead of "q_iter"
Why would it matter what the name is? There's no separate decl to stay
in
sync with. (That said, I'd be happy with "elem"; it'll be a matter of
the
maintainers to judge.)
Jan
I'd be ok with that too.
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
|
