[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[XEN PATCH 2/3] xen/sched: address violation of MISRA C Rule 8.2
 
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
 
- From: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
 
- Date: Fri, 14 Feb 2025 21:45:22 +0100
 
- Arc-authentication-results: i=1; bugseng.com; arc=none smtp.remote-ip=46.228.253.214
 
- Arc-message-signature: i=1; d=bugseng.com; s=openarc; a=rsa-sha256;	c=relaxed/relaxed; t=1739565955;	h=DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer:	 In-Reply-To:References:MIME-Version:Content-Transfer-Encoding;	bh=F6dLZHpAftKOEJLHOuiXBv1ROWYaaj6czWWml//vfP0=;	b=oviKzs0tnfmSMvkUg1ae9I4NMp+AGpxMtrjTWz7KMlJSjAJzhjnw7+x2fi4VMa5AQLTX	 02YxcshJDUkm7eKlH3WpSg68eJYZNO7IzGJrSEZWRCKKe4ubxqq2t7iucAfCUv8BOknBg	 ltJutQGsP6DmwIXPdGpR1akJqv/2XWwJDIygwXaFgsxXgITePLxwrt6HuWEga5Q7wYfVO	 uEg1qH2AF1yIF4lL/kvl+73j439Zdp2AmF0ZqmTPzLVLuGZntu+y2aHkY9f5daHtJ7O5p	 BjqPFQSPcSyHMe+v6aDATsvC0dqaQf1as2aZgzj/92hJgQvmeFVnDjbs9LBIFHz7rY3FY	 ic4+U0Ch9DzgHG2WKSPSnx2wGGBauaJu5ZU4gNMrtH+Etni9GS88GJzKtacTRcyFXdd9B	 aX/IqN/NuMYJuUymLhlNNlwtZblFNoG97wlYNTYVRTSCNIZTL0RkxKy5ny5ivZFh7u32C	 oL2XuhtVyeVY6nuyb5dX6iN5s/DgZP1p0HtUoNogjQELcLw6u7SVeR+OR2ItfzoSURSzW	 jwtBTapXsDjAEHnQtzIQg+NZTI4B+4aZ1rYGfTheMdaQTXS3Xt5f9OuFYJanqBd6AUXdm	 CF8SSTinOuVKsgKvrXjK/dsjLB2oXj8PhHsFAc0qN1tgC/hlMCKg4niLvea7wDY=
 
- Arc-seal: i=1; d=bugseng.com; s=openarc; a=rsa-sha256; cv=none; t=1739565955;	b=SRGrr3fWpxobkT6A8GTnCqfGSsQBST0I5DTyG9lsvRSxJ/stJC5nYLCHqzeOX3bL13Nz	 RaDeFCCB4uz2Gvk4hzwOMkS29/0It39M/KVLSohFkYnoVZcFZMaZJhdQ6qLginsodZ9C+	 DZiazjAxtqeWNLQlXJFzzd98zEJ9YcydDqioBF9NT71aEwqh21uyU6Um+WIiiOB+g32U6	 sKq5e67S9f3WHF3W4mB8Q4njU50sM1FdtMFVvIPuCP45+W66EaElwlEpu77b5NxCtTus3	 CltaL2vgSumf3txWHo8wdQ6skthayfTjURsgk8iGJyx4V9tl6AOyrH266Wu30qUSuOjtC	 0z/mzm4OmAVaRj1f3B10B4m8EJkixRrFlOwMHY8FE9sloPgwmxWn/G9h84hNeoZekORek	 X16AN903m+ot8Jml3ELcf5I2twsLO9Gwm5T5Frn2Ev/2JLvQR0ZBbHm6dXmwYqV9bMwwm	 af9Du4SpK/2tSAaZDZNdT9IzV8R0HDTEUn8MMbc1VqQ7VjZxWMElPjH/OUR/I+lVawE3g	 7cEAbZcS1RKrjMBQ+vRd6zITHnL7jtuG8Dbuh1nLE8OYWXR8VABSJhc45xMph7bp5PwA/	 90Yi5RGf/jLHcNpKHfg9uxMJAWda0yNP46Do/Z2DPTbhJil4o1T7X/3rlx87cpw=
 
- Authentication-results: bugseng.com; arc=none smtp.remote-ip=46.228.253.214
 
- Cc: sstabellini@xxxxxxxxxx,	michal.orzel@xxxxxxx,	xenia.ragiadakou@xxxxxxx,	ayan.kumar.halder@xxxxxxx,	consulting@xxxxxxxxxxx,	Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>,	Dario Faggioli <dfaggioli@xxxxxxxx>,	Meng Xu <mengxu@xxxxxxxxxxxxx>,	Juergen Gross <jgross@xxxxxxxx>,	George Dunlap <gwd@xxxxxxxxxxxxxx>
 
- Delivery-date: Fri, 14 Feb 2025 20:45:59 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
Rule 8.2 states: "Function types shall be in prototype form with
named parameters".
The parameter name is missing from the function pointer type
that constitutes the first parameter.
No functional change.
Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
---
This small fix is needed in order to keep the rule clean in the
follow-up patch that changes the Xen configuration under static
analysis.
I wasn't really certain about the right name to give to the parameter,
so if there are better options I'd be happy to accept them.
---
 xen/common/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/sched/rt.c b/xen/common/sched/rt.c
index f368e0fdd5a5..0300d2d2e454 100644
--- a/xen/common/sched/rt.c
+++ b/xen/common/sched/rt.c
@@ -500,7 +500,7 @@ deadline_queue_remove(struct list_head *queue, struct 
list_head *elem)
 }
 
 static inline bool
-deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *),
+deadline_queue_insert(struct rt_unit * (*qelem)(struct list_head *q_iter),
                       struct rt_unit *svc, struct list_head *elem,
                       struct list_head *queue)
 {
-- 
2.43.0
 
    
     |