Re: [PATCH 3/6] tools/libxs: Rationalise the definition of struct xs_handle

[Jürgen Groß <jgross@xxxxxxxx>]

On 18.07.24 18:48, Andrew Cooper wrote:
> Right now there are two completely different struct xs_handle definitions,
> depend on #ifdef USE_PTHREAD.  One is especially well hidden, and often
> escapes updates.
>
> Rework struct xs_handle using some interior ifdefary.  It's slightly longer,
> but much easier to follow.  Importanly, this makes it much harder to forget
> the !PTHREAD case when adding a "common" variable.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen