Re: [PATCH 2/6] tools/libxs: Rework xs_talkv() to take xsd_sockmsg within the iovec

[Jürgen Groß <jgross@xxxxxxxx>]

On 18.07.24 18:48, Andrew Cooper wrote:
> We would like to writev() the whole outgoing message, which is hard given the
> current need to prepend the locally-constructed xsd_sockmsg.
>
> Instead, have the caller provide xsd_sockmsg in iovec[0].  This in turn drops
> the t and type parameters from xs_talkv().
>
> Note that xs_talkv() may alter the iovec structure.  This may happen when
> writev() is really used under the covers, and it's preforable to having the
> lower levels need to duplciate the iovec to edit it upon encountering a short
> write.  xs_directory_part() is the only function impacted by this, and it's
> easy to rearrange.
>
> No functional change.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen