[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/shadow: fix PAE check for top-level table unshadowing
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 20 Jan 2023 08:49:28 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Io31DtRKRvzeaJ7vM0rAHgdD9I+lvUU4R06xLWV21w=; b=lYB5VGVedwlvv0ZUqH9xzUlfpnpoLSlG6vSzMoDzNpWlBhhOqWzRAsllLjiUIhOVBqJxzXkzNqFvDB7z0yaen7C6bAtYDp5b0HlAxcozw1DPT9NWtzd58vWhzJQ7BiSES26OQgQcHDx/wDi8Uc2c7YWLMdUd0P+SlIT0KeIRy5ScdTwfV7EJBWdlGW87JBs+MOTnwJoRvZpfGAM/m8HzMQ7ku8LAdCgkmA9dl+mlWM95FP40qf29NSdrkkgM+OWLOoNtWj/nPy+2vS4FyysHs4D+RvftXjV0Lu+GWQSCXMyKhtSTCXqbYhJAISRNUcKxqfmwSdTlzN4fzYt8VuletA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glAdSV3zasUryrrhg/wO0j2bk1ND626SnqRgPN0gDIVE20cM5Jd8N922AscTo6O5MUAXHSdp6HU3oktAGK9nzqEEBrBs2N0pDzAVe4M7k+PjJqQmaC0b7EyVCKRHS6hXL+CypJ1K8TIYnKPHVM0Ae/dEcuQpU/M7gx8ON399GzIK4kgNmO3MYwZufTHwhtn4QsyaUJJlyzOHffJ876cGHOVmnZM1k72vhcOmhGjeGt9BEcnzRKYsdcuqTahKcpPxMJ54Q4Rwed97ltwi/GRBeX7maaGs5UYdxxWXUuzhnn1Gf2Nb6sMvoQSbbuCCmkxj5dhev2tGSKZSgXS8LC+FEA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 20 Jan 2023 07:49:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.01.2023 19:19, Andrew Cooper wrote:
> On 19/01/2023 1:19 pm, Jan Beulich wrote:
>> Clearly within the for_each_vcpu() the vCPU of this loop is meant, not
>> the (loop invariant) one the fault occurred on.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Wow that's been broken for the entire lifetime of the pagetable_dying op
> 0 3d5e6a3ff38 from 2010, but it still deserves a fixes tag.
Oh, yes, of course. But then it'll really need two, as ef3b0d8d2c39
("x86/shadow: shadow_table[] needs only one entry for PV-only configs")
was also flawed, and I guess I really should have spotted the issue
back then already.
> Preferably with that, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks.
Jan
|
