[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] x86/shadow: fix PAE check for top-level table unshadowing
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 19 Jan 2023 18:19:26 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fQiIbHhHYgHKroBtPkv1gPMXRwxgEH8iH06KA3iq9zg=; b=jCk7+LwoufbJaj2bpehfX5X9ZdYvmX7lDuOYOOFnrGwfasZFyvk+hti7x4SI1JA/DrgoYS459vFGdf/9vN1A05L51sggPigMX7kt/2QK/wCEs8BEwOfg+401kTL3i0mkmyVWOcFPubfGgGEQYD4/acYL+BxLBhD31iZq9/gvKX77ybjau4TMTPocMNsfyIDYMCgtLGePI2lpw0EjsxadTQ+GSjdB8uZhAoOcLTtbKssf2gQ2BOBCBmzXfcIPuAda8oFA4C2OsQDaHr1kKKVRyAsFQv4iO4JtuymNqeGqY/X1th4sT0xqudc+rZ2bmIoBhfrBomd67+POee4maZDFsA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WEYbimqIXA2zceufJCtM0u5YMvFUCCHgyYbGdjv+LfTdRwv0Fo7v+XI7pTgL8LGvrFvGu5SbcB/qYy6hBtUjF6/uksWhVXBIBJLdknCVSRK+K3GTpMLqoDGIXpq+ocYdjsHoPn/LNmxlj1GSdDWb+O8a5Kqib2URbGYlVfxO1Wq2N42lleETGxB21ggdZhzfW8M6TGCI76lWKyrwNi8qufjrUJdiA3A5NiEiZxrMHgSWS/gdrU8zbAUH4kpUEM9lqws9FsOfC8kgrx9ZY/A8zjoXvRps898kylkAuqSXWD7LT1srqw9r6+eHYncjCPou0Qgj3SckDf2VYmX6zyRQLQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "Tim (Xen.org)" <tim@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>
- Delivery-date: Thu, 19 Jan 2023 18:20:05 +0000
- Ironport-data: A9a23:BG8T6qACDeXt+BVW/x/iw5YqxClBgxIJ4kV8jS/XYbTApD4mgjECy TYeCDvSb6rca2ugfY1xOdmy8UwCv5/VydBkQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GpB7wRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5MxxLk5yp fIhDzVObgmlu8Xoxu3nVbw57igjBJGD0II3nFhFlWucJ9B/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI/OxrvwA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE17WfwXyrA9J6+LuQ9adD2H2hhTAvMUNLCwe/kfyfrWGYcocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRwtJWFRHTb8a2bxRuuOC09PWIEIygeQmM4D8LLpYgyilfFSI9lGavt1NntQ2msn 3aNsTQ0gKgVgYgTzaKn8FvbgjWq4J/UUgoy4QaRVWWghu9kWLOYi0WTwQCzxZ59wEyxFDFtY FBsdxCi0d0z
- Ironport-hdrordr: A9a23:o3f6M6HQg1HG2J9gpLqE18eALOsnbusQ8zAXPo5KOGVom62j5r iTdZEgvyMc5wxhPU3I9erwWpVoBEmslqKdgrNxAV7BZniDhILAFugLhrcKgQeBJ8SUzJ876U 4PSdkZNDQyNzRHZATBjTVQ3+xO/DBPys6Vuds=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZLAik+GLprcTCdkai++VQyfbToq6mDQ2A
- Thread-topic: [PATCH 1/2] x86/shadow: fix PAE check for top-level table unshadowing
On 19/01/2023 1:19 pm, Jan Beulich wrote:
> Clearly within the for_each_vcpu() the vCPU of this loop is meant, not
> the (loop invariant) one the fault occurred on.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Wow that's been broken for the entire lifetime of the pagetable_dying op
0 3d5e6a3ff38 from 2010, but it still deserves a fixes tag.
Preferably with that, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Quitle likely this mistake would have been avoided if the function scope
> variable was named "curr", leaving "v" available for purposes likethe
> one here. Doing the rename now would, however, be quite a bit of code
> churn.
Perhaps, but that pattern was far less prevalent back then, and the real
cause of this bug is sh_page_fault() being far too big and sprawling.
~Andrew
|
