[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 1/1] build: replace get-fields.sh by a python script
- To: Jan Beulich <jbeulich@xxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 18 Jan 2023 19:38:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rgK9zWkhALHt0AKMO0FLonN4m6uVrC8df9zBDQoUOeY=; b=WqzM7cun4n32ge4X5UVry91JZ7n7BbhHxBIGhIBg6fi1JKjbyGJPkvUTSkacg58ZJ9s2uHsSrsfprP+q+KVitw3cWn47HbG/5jwkV+gUJ8fC/Heg/MHCSo0dbpdwWVsp/EtvtrwD8MZoAc6PvrRCeapuXQWyhlCm2PGf+c4bkvvw9UTjfn7TWTCluzO/LQgq2D3HZjQl9DTJz0O/hKgnwPiqnRhnYS6gAumFQnW6+bj8JRKTIdBJb7g1fiZ/3/7lTNFERPnkwifPvpl4OgGh8ixiidy+9gsq0SvTXuug5VOmSFwK0PjYA5VjrDmkadtxlbpgYZqEvv4MwoMy1baQvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUP8ZT2pa3Knt5qqUS1cSodemBC+D4cLGhY84Z3Ev/gj2zGvXmUuZqWV0JUBZ3aSwojcTltDs9PBPvh7p0qj04CUau9toShMCSxvzTlk1re9khOrvphWMviRyqVkIzt5DKp7h1aYCHfzTnqviLrFl6rw3+3POX2/C9gg3pyhKVIs47YKMu3PxzfZH1ZEdfTU9ZnRxyuWqukBd3R2yNqioBScQ/zCQL8M36RBLcTr3gn3wgLSWpbBXtG2IAYYNmWK3Dve7HFLZJfqZW7c6pem9VGoivVe7pgke0KXEjJGXQqSlMfW7dEmdkXVWjJ/M9QZ9CcfHONqJJeRiwvOGv0VqA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 18 Jan 2023 19:38:47 +0000
- Ironport-data: A9a23:HvALCaJC/k4uq/ePFE+RGpQlxSXFcZb7ZxGr2PjKsXjdYENS1WYHm DMfCziBafmMNGKmKNlxadi3oRsHvpXRyt8xGgplqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHv+kUrWs1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpJrfPcwP9TlK6q4mhA5wVuPa0jUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c56Anxwr qMKOgsSLUG9q9Dun6zgavNV05FLwMnDZOvzu1lG5BSBUbMKZM6GRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/VspTSNpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eexnmjAtNORNVU8NZLgkCCxlwoUCYxFkOigt7+jEqAYcpQf hl8Fi0G6PJaGFaQZtv3UgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmL+ITXOQ8J+EoDX0PjIaRUcZfjMNRwYB59jloakwgwjJQ9IlF7S65vXqHRngz jbMqzIx74j/luYO3qS/uFzC3TSlo8CVShZvvlmJGGW48gl+eYipIZSy7kTW5upBK4DfSUSdu H8DmI6V6+Vm4YyxqRFhid4lRNmBj8tp+hWF6bKzN/HNLwiQxkM=
- Ironport-hdrordr: A9a23:xdysYqtK+bN+RU4g3KW8Q8S+7skDYdV00zEX/kB9WHVpm6uj5q KTdZUgpHzJYVMqMxsdcL+7VZVoPkmskKKdjbN8AV7BZmfbURqTTL2KhLGKqwEIcBeeygcy78 hdmqFFebnNMWQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZKdXmSfLi4OljAEm5WNlNB2w+ZK6i3JyAgAD3LQCAAMFwAA==
- Thread-topic: [XEN PATCH v3 1/1] build: replace get-fields.sh by a python script
On 18/01/2023 8:06 am, Jan Beulich wrote:
> On 17.01.2023 18:21, Andrew Cooper wrote:
>> On 16/01/2023 6:10 pm, Anthony PERARD wrote:
>>> + elif re.match(r'^[a-zA-Z_]', token):
>> [...]
>>
>> All of this said, where is 0-9 in the token regex? Have we just got
>> extremely lucky with having no embedded digits in identifiers thus far?
> That's checking for just the first character, which can't be a digit?
So it is...
But nothing good can possibly come of having a token here which matches
on the first char but mismatches later.
>
>> P.S. I probably don't want to know why we have to special case evtchn
>> port, argo port and domain handle. I think it says more about the this
>> bodge of a parser than anything else...
> Iirc something broke without it, but it's been too long and spending a
> reasonable amount of time trying to re-construct I couldn't come up
> with anything. I didn't want to go as far as put time into actually
> trying out what (if anything) breaks with those removed. What I'm
> puzzled about is that argo and evtchn port types are handled in
> different places.
>
> For the domain handle iirc the exception was attributed to it being
> the only typedef of an array which is embedded in other structures.
I refer back to "bodge of a parser".
~Andrew
|
