[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 1/1] build: replace get-fields.sh by a python script
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 18 Jan 2023 09:06:12 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RcjF/V17acJHqxI6kFqCw+dxflXgn48UFej3AAMu1Pc=; b=HadsNJyOs1zPyiR9qq8OW656uBah1OM3nPkxxcCuB3KnKhHnLhupSh5E1AyFNdrvxUp1eeRQycrhkprLROnoEXoKeO++7kx8xe+G8M6WQRpyUncqHy5DPT0hkqIaM55EDi7+ca7eyPjHvYhBz+kf6qhJ3j0PJgL00npzB32QXvfm1lUeqwUD1O3WpVtflTjvzoFrCEjzXIRd/fvSTMlBziehwwiWPHix2fFGQa55LTILgHTae0Z8OXAxljvRUyiEcqpzWZsYWejL848VsKW63YvRl/w8y/3teTM3NUWD61zFgm+Ee7W8fdPEMB14VjDaqddd9mURcgrFBLamIQMHpw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZVkZxLwoQX2MKOmJ8MeiY8uWk+VlZFsmzNQjaZHBQ0/84JlIxpRYy8OMBzoXvHU6ah4LXh2x38zUCYpbrg4fKvtcaLVVVy1J1sEI/Ms3535N1SKRiVhIZaPiIr4FgM8rkL5Fgc9L+z15Xk9hBfu792215wuFDZYEFkhqYvSzd4Ls2kPLT0crX2AK2iUfCFIT+wO0pYdJAPZP3Vgubh75ia9ZREW0psySuOSp39CowYRixL8se0F94cnSEqHuJFzTEgwwXrAJsxyqN7xZrv2aDSPYf9qABah6c0+rsRf9GxhTdY5wW1/hvhZJLUPTvoLhC2j/y1NTDdANawxCvmvCQQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 18 Jan 2023 08:06:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.01.2023 18:21, Andrew Cooper wrote:
> On 16/01/2023 6:10 pm, Anthony PERARD wrote:
>> + elif re.match(r'^[a-zA-Z_]', token):
>
>[...]
>
> All of this said, where is 0-9 in the token regex? Have we just got
> extremely lucky with having no embedded digits in identifiers thus far?
That's checking for just the first character, which can't be a digit?
> P.S. I probably don't want to know why we have to special case evtchn
> port, argo port and domain handle. I think it says more about the this
> bodge of a parser than anything else...
Iirc something broke without it, but it's been too long and spending a
reasonable amount of time trying to re-construct I couldn't come up
with anything. I didn't want to go as far as put time into actually
trying out what (if anything) breaks with those removed. What I'm
puzzled about is that argo and evtchn port types are handled in
different places.
For the domain handle iirc the exception was attributed to it being
the only typedef of an array which is embedded in other structures.
Jan
|
