Re: [PATCH v4 2/4] xen/riscv: introduce sbi call to putchar to console

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2023-01-18 at 08:38 +0100, Jan Beulich wrote:
> On 18.01.2023 00:32, Andrew Cooper wrote:
> > On 16/01/2023 2:39 pm, Oleksii Kurochko wrote:
> > > +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
> > > +                        unsigned long arg0, unsigned long arg1,
> > > +                        unsigned long arg2, unsigned long arg3,
> > > +                        unsigned long arg4, unsigned long arg5)
> > > +{
> > > +    struct sbiret ret;
> > > +
> > > +    register unsigned long a0 asm ("a0") = arg0;
> > > +    register unsigned long a1 asm ("a1") = arg1;
> > > +    register unsigned long a2 asm ("a2") = arg2;
> > > +    register unsigned long a3 asm ("a3") = arg3;
> > > +    register unsigned long a4 asm ("a4") = arg4;
> > > +    register unsigned long a5 asm ("a5") = arg5;
> > > +    register unsigned long a6 asm ("a6") = fid;
> > > +    register unsigned long a7 asm ("a7") = ext;
> > > +
> > > +    asm volatile ("ecall"
> > > +              : "+r" (a0), "+r" (a1)
> > > +              : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r"
> > > (a6), "r" (a7)
> > > +              : "memory");
> > 
> > Indentation.  Each colon wants 4 more spaces in front of it.
> 
> Plus, if we're already talking of style, blanks are missing
> immediately inside
> the outermost parentheses, requiring yet one more space of
> indentation on the
> subsequent lines.
> 
Thanks Andrew and Jan for the comments. I'll take them into account.
> Jan
>