[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/4] xen/riscv: introduce sbi call to putchar to console
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 18 Jan 2023 08:38:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zPSKKHQPH7bBkW3Yq+y1pEXmvB1EI+8zZGED24kyGOY=; b=RF9KJMSe1TaqhavDPcJ+Xee8DvLvo7wAQ8lOATLMWiCMMyqHIBscuqGM4A9L5V/SFy5luZdHU78YDPIi/5zCfi9HD6SVpQdzPP5Zy+vIP6SORWe0G0JZAMNIFnYw7juYVLSW8Qo4+reoAjVToHG34rHDKHYYdecoPJ7yxgeZ4UKhZTmDfZOClVkQWch6AaB2RjCrM0AePTx6lfblmRKCz/R3nwaBxQwOvklpG4Es+GOP76SExf8kv30/yos8X0blIZ0BXAaqwiD3vFZhDxBs6hj5dIgrZyDXv9tdnhZErpeYjr848oeFhhsxcQUD4bZqaStD1KYnyvRdgxK+IBmkNA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mmfQ+68iO4L/aDnbDtAg8K9SJwrNM7Pth6oncxND7iFLbC8Cp0i+DQj5gnmJOuvRsFwLXfblnHyVTOrFh6r4PYH1y+K0EZLpHcDzPgfD6jc8pPSQyZNqHRQbuf5lSq8sFsajvBOwTLvfZhRbtDM5JjRmQXYUY3oTiQdh1KRoAfB3hGoH0xNuT6jh0e5jj0yqoDoy8DaTAO8VTsvL48qpW96cz+1Q0H4QdCCWMlaC/OhkXCU7ZDCohOmEDPlV11sXVhxj4YPIe5C9qYulcZSnlSA/l84qfeXuqp4qjm7iuKgQhSrLklPPKySYfcYO4PFDQuxbNcDAjqvpRdO4oAXj+Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Gianluca Guida <gianluca@xxxxxxxxxxxx>, Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 18 Jan 2023 07:38:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.01.2023 00:32, Andrew Cooper wrote:
> On 16/01/2023 2:39 pm, Oleksii Kurochko wrote:
>> +struct sbiret sbi_ecall(unsigned long ext, unsigned long fid,
>> + unsigned long arg0, unsigned long arg1,
>> + unsigned long arg2, unsigned long arg3,
>> + unsigned long arg4, unsigned long arg5)
>> +{
>> + struct sbiret ret;
>> +
>> + register unsigned long a0 asm ("a0") = arg0;
>> + register unsigned long a1 asm ("a1") = arg1;
>> + register unsigned long a2 asm ("a2") = arg2;
>> + register unsigned long a3 asm ("a3") = arg3;
>> + register unsigned long a4 asm ("a4") = arg4;
>> + register unsigned long a5 asm ("a5") = arg5;
>> + register unsigned long a6 asm ("a6") = fid;
>> + register unsigned long a7 asm ("a7") = ext;
>> +
>> + asm volatile ("ecall"
>> + : "+r" (a0), "+r" (a1)
>> + : "r" (a2), "r" (a3), "r" (a4), "r" (a5), "r" (a6), "r" (a7)
>> + : "memory");
>
> Indentation. Each colon wants 4 more spaces in front of it.
Plus, if we're already talking of style, blanks are missing immediately inside
the outermost parentheses, requiring yet one more space of indentation on the
subsequent lines.
Jan
|
