[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Mon, 16 Jan 2023 12:01:20 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4yomIzoPDfG9YMo+xQOuq41a+sPGuYd7VcrscX3EIA0=; b=R3KOGKSYJo+VVTh6dwUboHkTa8Zb+bnxtlSA54SPZgfJBP3SaGcsfdVQ4pXda3NsQpdxayQjxnrgBAj8V39iEauWGcH/IjyJcU6lMEJcD77PasEGcTeRWyvNeHTs7vmIwnT9GJ/ORVAsRU1VQvS8iGrUkK9jEQNtB35bWw84CiyPyBe4oQThATaflajG7TdNNkHu4QjuUcE4ZHD5Wyz6YO00Qp6M1MqCRc2xBaTJvyGM59N+AEnmASmRQu1FvVhXgcVi638oD1FKEKX37km60c4rggME3GE+Px5DLA4ecWwEnOBv55dR7vX8iO7g5N6bqgZRM8KSUiILB7apYZdpVg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jFZCmVrwNlCcBQEwgGCylnUrdcXuNkd5CR9nRrFlicM4mjOUL662M7f++sfulQhaIFwCoCSdZs4ih+OyEkDsAJu7Bg2Vm/e0pzG+MTYR56J7fy5TCJLkZmBkHL2fC6mKHdPxx25zz/WIjcFGdaipJlR/THWP0aDODdGMW35sqfmdHCpv/j5QmFhBBwS7MiBGZmZdStZJVYGqpE39pMBw1fOiMfMYuLvSVs7PpDZI0XjUjGLWVAKveuEqFBsDYyv1nCH+qstr+icaiol6cUC0UeFjk/FHcubI04uIUuvaRRB9jJ7pRBgctyQsZ11f7XkyksYljjC7do66XpQ+BlSCLw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jan 2023 12:01:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZJNEXNkX9GZxGhkCgYl8odWGCka6X2i6AgAJ2fxCAAB/FgIAGXWYAgAAf/4CAAAyvoA==
- Thread-topic: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2023年1月16日 19:15
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; Julien
> Grall <julien@xxxxxxx>; Bertrand Marquis <Bertrand.Marquis@xxxxxxx>;
> Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>; Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>; George Dunlap <george.dunlap@xxxxxxxxxx>; Wei
> Liu <wl@xxxxxxx>; Roger Pau Monné <roger.pau@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 02/17] xen/arm: implement helpers to get and update
> NUMA status
>
> On 16.01.2023 10:20, Wei Chen wrote:
> > Hi Jan,
> >
> > On 2023/1/12 16:08, Jan Beulich wrote:
> >> On 12.01.2023 07:22, Wei Chen wrote:
> >>>> -----Original Message-----
> >>>> From: Jan Beulich <jbeulich@xxxxxxxx>
> >>>> Sent: 2023年1月11日 0:38
> >>>>
> >>>> On 10.01.2023 09:49, Wei Chen wrote:
> >>>>> --- a/xen/arch/arm/include/asm/numa.h
> >>>>> +++ b/xen/arch/arm/include/asm/numa.h
> >>>>> @@ -22,6 +22,12 @@ typedef u8 nodeid_t;
> >>>>> */
> >>>>> #define NR_NODE_MEMBLKS NR_MEM_BANKS
> >>>>>
> >>>>> +enum dt_numa_status {
> >>>>> + DT_NUMA_INIT,
> >>>>
> >>>> I don't see any use of this. I also think the name isn't good, as
> INIT
> >>>> can be taken for "initializer" as well as "initialized". Suggesting
> an
> >>>> alternative would require knowing what the future plans with this are;
> >>>> right now ...
> >>>>
> >>>
> >>> static enum dt_numa_status __read_mostly device_tree_numa;
> >>
> >> There's no DT_NUMA_INIT here. You _imply_ it having a value of zero.
> >>
> >
> > How about I assign device_tree_numa explicitly like:
> > ... __read_mostly device_tree_numa = DT_NUMA_UNINIT;
>
> Well, yes, this is what I was asking for when mentioning the lack of use
> of the enumerator. Irrespective of that I remain unhappy with the name,
> though.
>
How about DT_NUMA_DEF or do you have some suggestions for the name?
Cheers,
Wei Chen
> Jan
|
