[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/17] xen/arm: implement helpers to get and update NUMA status
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 16 Jan 2023 12:14:45 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GEhwphNCYfyS6Z7ABBAnU5IV5efcZTpY+saNniqbPX8=; b=epxfjgky1KbzlzdVBDUn5+qsMF5B4lm+39g5JnD0zSR70VCGZQ1R+1a9G8ou4V+lQbhvepdAtIde/LO42mLylnDGj3racaFXvlN3992uekcTW8D16FqtdSc8BwXA2LEIYP92iTC0yPrBZvQfkOAQkGZd9fha9GQKohCInnfkKVzre4cprkXbRn3Jo+AESvN7IwI7RR97Jv3OnC+IxZGkw2Fx9TtJkK5ReEueioxGvKbqhSIAZN4MsqaFt1zp7sE1YDCboe8f2Nqyeg/WsUpoNnDoWdGfDX7rL+FNWWouDHqPAVc/ONtvVTCrMEeHb2Ob/B9BAwWDukCcYnLPGEKMMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M3c3Tl76cMDB3nz4p7F5UO0NzmxjhvLU+qghavBHzpILyxAIjgXUl5WmJYoRSOBBzlwm9fDArxBYSE0G/VOD6Y5bfjyFzoFUWBmg3mrdwEtLWe4hYAhUbhGfhMvym6A/IVueFFJpAOqC6gaDt6m8SSpV9vTYydHFVKtZJzvgt0MRhi8kaTwlS1baLZbjtsLTib3I96IO0scv/6xfRhgf3xvyWMGY9mD/WFMUr/ikToYWEnn5V5FkfyAJEoSpH3YebFoyS7Ybwr9NUFBIADH9n0akzntAiOQkVwy3K1+GdxMFvsE6mLqSgleUV+U0pXFFCY4wzTWiNaa2fMT02HdvTA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd <nd@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 16 Jan 2023 11:14:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.01.2023 10:20, Wei Chen wrote:
> Hi Jan,
>
> On 2023/1/12 16:08, Jan Beulich wrote:
>> On 12.01.2023 07:22, Wei Chen wrote:
>>>> -----Original Message-----
>>>> From: Jan Beulich <jbeulich@xxxxxxxx>
>>>> Sent: 2023年1月11日 0:38
>>>>
>>>> On 10.01.2023 09:49, Wei Chen wrote:
>>>>> --- a/xen/arch/arm/include/asm/numa.h
>>>>> +++ b/xen/arch/arm/include/asm/numa.h
>>>>> @@ -22,6 +22,12 @@ typedef u8 nodeid_t;
>>>>> */
>>>>> #define NR_NODE_MEMBLKS NR_MEM_BANKS
>>>>>
>>>>> +enum dt_numa_status {
>>>>> + DT_NUMA_INIT,
>>>>
>>>> I don't see any use of this. I also think the name isn't good, as INIT
>>>> can be taken for "initializer" as well as "initialized". Suggesting an
>>>> alternative would require knowing what the future plans with this are;
>>>> right now ...
>>>>
>>>
>>> static enum dt_numa_status __read_mostly device_tree_numa;
>>
>> There's no DT_NUMA_INIT here. You _imply_ it having a value of zero.
>>
>
> How about I assign device_tree_numa explicitly like:
> ... __read_mostly device_tree_numa = DT_NUMA_UNINIT;
Well, yes, this is what I was asking for when mentioning the lack of use
of the enumerator. Irrespective of that I remain unhappy with the name,
though.
Jan
|
