[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 06/14] xen/arm32: head: Replace "ldr rX, =<label>" with "mov_w rX, <label>"
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 14 Jan 2023 00:51:15 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BDawBXf0X7erUZK9/UtOPiy/nfqfVb+0dAYYMjOInqA=; b=kXA/dHmt7TWt0suLGzcSwsPvf9r24rPhkbtCPHQjv1DkzQOgQxbg06KKlrV7BO2/TDePRl6u3C7Gm5T/WIMd40VyMlkV0hAYH8OY5yNvsHSOazNlCRK6Mg+CMV9UExuSjwe4BjfP/DjHVZYRfERSfS+hBdjZJK/NPt7ya+CqDWxwOfK+5JdbUX0vHLjeD9EB1WR3vlCe5iSN7kOuxX6WR2CwoKkh2UrgpnRcrxQa/RnGGMWChtT/BnBUVFpB67TQl9BZ9LXZ9zHnmvSjdzw4Dak3Okl/eWcYlnt7lTbvYiXdHamgoZJ9MF4rPHdbUbfh47QaCA8zdB5b9obrzvyynQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z7fq17/uoVzhxXfMb7blPTIbhqblIOUuhrus6S2TahRxGFmwWTxryspkVgh3/9aWhct9wRjVOsRXno2fZbbeKVveFhkQgVV+NwNr8fYNNuCPhnKJcj4N5si87nYscg852vZ0UgSt0wcrJZspaFYeRFIMYYYhv7hxeFFqUweDmktjOXPBhn8CPKrBZyluMSYWJ8z1YSrLb9nBpc8iGYp9TlzhobDuoghOTmszTBUm3f5jqTjLW0iXMFLiWll7yfVR6NOLtzlEQdieEx1BkWk6r8jIxpCMKtzLMMr7H28nG+RmNt93uoe8WSviEk1H7035mbOA7BxurK1XOf6DqC4gRg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Sat, 14 Jan 2023 00:51:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZJzeChOboto8YKEqIP7caZFvxO66dC3QQ
- Thread-topic: [PATCH v4 06/14] xen/arm32: head: Replace "ldr rX, =<label>" with "mov_w rX, <label>"
Hi Julien,
> -----Original Message-----
> Subject: [PATCH v4 06/14] xen/arm32: head: Replace "ldr rX, =<label>" with
> "mov_w rX, <label>"
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> "ldr rX, =<label>" is used to load a value from the literal pool. This
> implies a memory access.
>
> This can be avoided by using the macro mov_w which encode the value in
> the immediate of two instructions.
>
> So replace all "ldr rX, =<label>" with "mov_w rX, <label>".
>
> No functional changes intended.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
I've tested this patch on FVP in arm32 execution mode, and
this patch is good, so:
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
