Re: [PATCH v4 06/14] xen/arm32: head: Replace "ldr rX, =<label>" with "mov_w rX, <label>"

[Julien Grall <julien@xxxxxxx>]

Hi,

On 13/01/2023 10:45, Michal Orzel wrote:
> On 13/01/2023 11:11, Julien Grall wrote:
> > Caution: This message originated from an External Source. Use proper caution 
> > when opening attachments, clicking links, or responding.
> >
> >
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > "ldr rX, =<label>" is used to load a value from the literal pool. This
> > implies a memory access.
> >
> > This can be avoided by using the macro mov_w which encode the value in
> > the immediate of two instructions.
> >
> > So replace all "ldr rX, =<label>" with "mov_w rX, <label>".
> >
> > No functional changes intended.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> >
> > ----
> >      Changes in v4:
> >          * Add Stefano's reviewed-by tag
> >          * Add missing space
> >          * Add Michal's reviewed-by tag
> It looks like you forgot to add it, so to make b4 happy:
Ah yes. Sorry.

> Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
Thanks! I also forgot to replace the "----" with "---" before sending 
:/. I am not planning to respin the series just for that.
Cheers,

--
Julien Grall