[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice()
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 24 May 2022 07:54:49 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=timeout (key query timeout) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v45FNKZHlF0GnLYYuSmMGrMkCffo4bOgTyZdlwQFxP4=; b=UQFLv5FnmANDvughLj0L1QF4qocGLMK47iS+daKgK7mW3MBML4NDn15/RRzwoGU0g/gGBuYSxBsW0h3d+VxugSkVc6lHY3nk2EFot9uUjqhlLr77tZtMOdfWuxEgVHfxDT7zgw/ZFsps3XN2lMhHM+OM0jvkWzYVk8mfCofEHC8fxyHX2+kVh2KCqg/MAooU3rdbDpc6oL4eHaxE3o2F12sPJ3XJ6A3AWxN24gyiIU08ELxwTssfN5QKFurHH1b7g5ntw2mKAb+QEYnjPDlzVuc0RbQqc30I8N9bNieInOrc+cQCTH/MbQ+VlWVJr3ed8aqYiYHVUkhB+g6sleZGPA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v45FNKZHlF0GnLYYuSmMGrMkCffo4bOgTyZdlwQFxP4=; b=lGh2+bG0gBX0ZV7vOx6r69Xe5wtsgOrkA8LgEZxn4MHR9UcSheSTKzJ/b2MEr+grJ+xA2S/9ePAoNGN6XMgl7PchCyvh6tcVNRI89YUQZwrJhuuAIEHmKmWpwFT9kyJJCxD0PNXyVkTeK6n/4jCrB69EYu80GJbzWCAOOg7O8fBSC9NWT0BbhsPScCIO6TrqqSFJw/08mUSOdygHLIS3DYxOO+9BtrsbSqSmKjBkSd9cp6ZIHyQ73WkX88+6665vddFI6EUyves9XXSGwsEMyfrQWxrGtZA9VX59d5KM4Vke0+kOKxRkmDPKjtISiNDO+h9a7T0kKQ1JZSSdPnlQzg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b6L8jXnHLpL5vKq/GYxvuphxjOJNbOFpi7iCwga1FoxBtDS1cdzEXw/oXuqTOEAWOhqJDPZAJ92RkA/4Fjmk/KqKkKgWwET/6TGOxI/5IC8wpvt5zgP8mqmmvWjHi2QnwCrlExz9pPvtnmDjDHxDc6r1o5HldbY3vcE2NKMreFzUAWwHCHZSGctHqR8qREFi043pScneD1g02W4OGmbgJo7M+yLoaUnkMEUlKoH7mK+/uH+X+HNCk97uZnZRAEI2/00hcAMmeShU4oS3h7IuASib1ZvJxAPqCgLWyxWIQNtRTJu1M3S9atAz9vRDop9A905PMjFa0XySWlSDqpJEdg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ONseBJqNOrKzGGzzhXMagDlR9SmXR8grM7OeHq3GPsP1cGD4SEGnNDgcDzEB5nyXO4AetiS3PGpLjWCidS25vU5ngIiR1bTBTgSc12jPEa6RMVohZU3/HHe72UXJ/IWpjU2FAevm2YrHmJ10uTVyhamAnARbHzHsYTS83PfdADBqWpCKxrMmnM/IeaRqZBYzxkJ/e109EPH740hRfyP2gcXMeSsd7ezwIP0BmvJC5okk7ENDjfoyS3gDFERnChdVtfm9j1LiUqF3R2xrBrOj0CwjIxtbh4QqDExU6PRSUtoL8f1gc5gsjPD6zBPYY5Wgefke+RAplVyQ5/oj/0Rlaw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Tue, 24 May 2022 07:55:06 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYbf1I/4cyEYG0EkCW5QIQgj3DOK0tqxkA
- Thread-topic: [PATCH] xen/iommu: dt: Check the return value of xsm_deassign_dtdevice()
Hi Julien,
> On 22 May 2022, at 17:59, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> xsm_deasign_dtdevice() will indicate whether the caller is allowed
> to issue the operation. So the return value has to be checked.
>
> Spotted by clang static analyzer.
>
> Fixes: fe36cccc483c ("xen/passthrough: Extend XEN_DOMCTL_*assign_device to
> support DT device")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
With the typo spotted by Michal solved (can be done on commit):
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> ---
>
> Platform device-passthrough is not security supported. Hence why this is
> sent directly to xen-devel.
> ---
> xen/drivers/passthrough/device_tree.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/xen/drivers/passthrough/device_tree.c
> b/xen/drivers/passthrough/device_tree.c
> index 98f2aa0dad68..1c32d7b50cce 100644
> --- a/xen/drivers/passthrough/device_tree.c
> +++ b/xen/drivers/passthrough/device_tree.c
> @@ -269,6 +269,8 @@ int iommu_do_dt_domctl(struct xen_domctl *domctl, struct
> domain *d,
> break;
>
> ret = xsm_deassign_dtdevice(XSM_HOOK, d, dt_node_full_name(dev));
> + if ( ret )
> + break;
>
> if ( d == dom_io )
> return -EINVAL;
> --
> 2.32.0
>
>
|
