[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 5/6] tools: Use new byteswap helper


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Lin Liu (刘林) <lin.liu@xxxxxxxxxx>
  • Date: Tue, 24 May 2022 06:52:31 +0000
  • Accept-language: zh-CN, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JBesWdDLE7XH0mMmKBbgrgVOHPAfiXnfq6JIlvEC5FU=; b=jrbBRAtGFO6GwcUpSCtsl/rKsojCpw1wBCm314kYFGkhKiH02mOgnLnlrgSZ8mbtVjbzQo/6b7a2Nll6obqsaw97XBNZmiAKpf8XPk+HfXwhMXd4L3VS50NH+XBDrhLsdwsm4mRh0ZUzeG2inYeF/igTp8fPdL2NgDZOfMQhTcl2gt/MP8LPjzY/973Ap0km0pdWIKibyjeC0etWnjhh5mM15bkuqNk1itVyD9JfT5gL4VOeBOAavx2RI9k5YwhBQ18kuGtuoldF3JVO4L2TCc6q6LwvEErR6tBjoyrRyRuGQNKMuOTkbxBNrqsPrYy0w6sheGrqvZinkRhWflCwmg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R2EybRfkPzkjfmQI94R1a+EJuI5PZY/MXcZgNjdV/24HRQFHghX1JoMFRysKmXOVnDehySvYENdTWPRLaG6EPhnC9h5wgvd6od7k/X3LhDcUYN2FE3S7+UDVmgH3vYg/a53lFI87U8h50ZnRmjs5VNmLvVWPfkqJuMgyYE7etA3QUOM62K1ZtcTB4lex/xoRkYBrmx2v8EZwhTTN/V79EtZdwfoNLuYDG7jbUlDyZkU+VYqr/jViK91pEh09yEnWgBsVdtNwSo4ZUqc5kE+ReNuunZKIiQW9OjLXnrZDvOvGx97thf5KzDYNE7q6/R0a4rAGl5AfDCw6C2TasF9pBA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 24 May 2022 07:42:19 +0000
  • Ironport-data: A9a23:FfduP6i6zloNWQAQGMu1QwlnX161ZREKZh0ujC45NGQN5FlHY01je htvCGjQPKyDambzKdF+bY+w/EwG6pPdxoNlGVM6/ns3RSgb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M68wIFqtQw24LhXlnR4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YVs5G43MouclaiZjTAZ0eo5r8o/cDmfq5KR/z2WeG5ft69NHKRhveKY/o6NwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIEehWhr7ixNNa+2i 84xbTtpKhDBfjVEO0sNCYJ4l+Ct7pX6W2IC8AjK/vpvi4TV5C9B9eizYMX4QfHJY89YgHa3h DKd8U2sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRokyxQdVEM GQP5zEj66M18SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/Qjvc4yADctj 1mAmoqwASQ16eLOD3WA6r2TsDW+fzAPKnMPbjMFSg1D5MT/pIY0jVTESdML/LOJs+AZ0ArYm 1iixBXSTZ1K5SLX/81XJWz6vg8=
  • Ironport-hdrordr: A9a23:Q9nVaK58FhneAEQFpQPXwX2BI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTP2ftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U 4CSdkyNDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9p1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUZpDKh8KoDOCW/sLlXFtzesHfrWG2nYczGgNkBmpDu1L/tqq iJn/5vBbU115qbRBDJnfKk4Xid7N9p0Q6v9bbQuwqdneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2KIoM3R3am+a/hRrDvDnZPiq59hs1VPFY8FLLNBp40W+01YVJ8GASLh8YgiVO 1jFtvV6vpaeU6TKymxhBgl/PW8GnAoWhuWSEkLvcKYlzBQgXBi1kMdgMgShG0J+p4xQ4RNo+ 7ELqNrnrdTSdJ+V9M0OM4RBc+sTmDdSxPFN2yfZVzhCaEcInrI74X65b0kjdvaDKDgDKFC7a gpfGkoxFLaIXied/Fm9Kc7gizlUSG6QSnnzN1Y6txwpqD8LYCbQxG+dA==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYbordwufrrqV0k06ypnfJmfxjlq0sTnKAgAD4X1GAAEYaAIAAC20q
  • Thread-topic: [PATCH v4 5/6] tools: Use new byteswap helper

>> On 23.05.2022 11:52, Lin Liu wrote:

>>>> --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>>>> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c

>>>> @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p)

>>>>        return cpu_to_le32(*p);

>>>>  }

>>>> 

>>>> +static inline u32 le32_to_cpu(u32 val)

>>>> +{

>>>> +   return le32_to_cpup((const u32 *)&val);

>>>> +}

>>> 

>>> Why the cast? And why not uint32_t?

>>> 

>>> Jan

>>

>> le32_to_cpup has following prototye and definition

>>

>> static inline u32 le32_to_cpup(const u32 *p)

>> {

>>         return cpu_to_le32(*p);

>> }

>>

>> xg_dom_decompress_unsafe_xz.c redefine and use u32, use u32 to keep consistent

>> typedef uint32_t u32;

> 

>This answers neither part of my question. For u32 vs uint32_t, please

>also see ./CODING_STYLE.

 

Type cast is unnecessary, will be removed in next version of patch

CODING_STYLE encourage uint32_t instead of u32,

However, Current xg_dom_decompress_unsafe_xz.c already use u32 instead of unit32_t, so I

use u32 to keep censistent, otherwise, the code look strange


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.