[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] x86/cpuid: expose MCDT_NO to guests


  • To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 13 May 2022 14:32:32 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0iEa3rG66BGk+Kc8prOOuBxOgEguZjAo0hFGK7M2byQ=; b=KyZoLum9oR/9ZUmNxNmObQrlbbEfOu0h4CNsvq0As4cFEZP03HevTuwue9b537sr2i/jIemcO5oWsvY7PQslfAxCwGl1ncND2R3hKstPtA3G5jjTBJd93Loo7PkTlHsLzcdQROhTtyySaQGUxCfyh0lQMDh32GwY9xGJLyf99enLmi6dvJTwHsNh7Ttfr2BSLTGxXiZTt2RymNYHaLNfmdv0jQMgvXYqaL9MlSjFZMMuTuMMDTAcqoXicK3Cm/AzUS9xXCGR4K8hbKJk9FXcAUJBejlILS5p533OORR/bFQCtiCRyTKLeqqblVnZi2nt9y/UsMl3Xb88Gl8gs3UAkA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mUzfg1ka6kG8vmua+fb3uzdMKH5jB0qrdD+kBzuTzc87Je67zh+HcLbwQBB88Er/CKIixBBkugf8wL3ptzs5pHc0zlpW5Ae7vGf5zVwyQT4Q8MijcoYKvnsK/wfJBYwZQspXS/zsaqS7JT4uxGp267gI9RdmFNIxLGL8D0a/UrL9JgVOebPrfBvYxWQw3ZbVGNMeSbibrVI8ysEanjCAVsS9qlMQE8cle3rb1o4K+kiBODU7b3avfntDTc5iRiI+Fz8t00nrCgtkPdZXuYTafP8Dg4nfYSV5/NMMFHzZnzUDGTBCULALJunG139HSdazrVR4wUYN7mxOAMXei3QQjA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
  • Delivery-date: Fri, 13 May 2022 12:33:04 +0000
  • Ironport-data: A9a23:OWrZHKPH9weE0zvvrR2ilsFynXyQoLVcMsEvi/4bfWQNrUongzMBz GtOWDqFOK7camHxfdsnad6+8kkG6pCHztAxGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFYMpBsJ00o5wbZk29Uw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z5 9lun4yLcFkQY/fg288XUwVTFwRUBPgTkFPHCSDXXc276WTjKiKp79AwSUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HtaaHP6iCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/33yCmLGUC8zp5o4Ip+HP64gVy1YG8c9aEYMKQecFbk0qX8 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTvv2RmkO4HdVFJ CQ8+CU0qrMp3Fe2VdS7VBq9yFaGtBMBX9tbE8Uh9RqAjKHT5m6k6nMsSzdAbJkqsZEwTDlzj 1uRxYq2XnporaGfTm+b+vGMtzSuNCMJLGgEIygZUQ8C5Nqlq4Y25v7Scute/GeOpoWdMVnNL /qi9kDSW517YRY36piG
  • Ironport-hdrordr: A9a23:nGzb2a7p4VomdJL2IwPXwVqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc6Ax/ZJjvo6HkBEClewKlyXcT2/hrAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCZSWa+eAcmSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AXV0gK1XYcNu/0KDwVeOEQbqBJaa Z0q/A37gaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VJN1xNvdfWVa9Ny4lDgqpUCfaPZBCHU7xgLjKx5hwzN2WWfUzvekPcd L6IRlliVI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, May 13, 2022 at 11:06:01AM +0000, Andrew Cooper wrote:
> On 13/05/2022 11:34, Roger Pau Monne wrote:
> > diff --git a/tools/libs/light/libxl_cpuid.c b/tools/libs/light/libxl_cpuid.c
> > index d462f9e421..697ee38270 100644
> > --- a/tools/libs/light/libxl_cpuid.c
> > +++ b/tools/libs/light/libxl_cpuid.c
> > @@ -235,6 +235,7 @@ int libxl_cpuid_parse_config(libxl_cpuid_policy_list 
> > *cpuid, const char* str)
> >          {"fsrcs",        0x00000007,  1, CPUID_REG_EAX, 12,  1},
> >  
> >          {"intel-psfd",   0x00000007,  2, CPUID_REG_EDX,  0,  1},
> > +        {"mcdt_no",      0x00000007,  2, CPUID_REG_EDX,  5,  1},
> 
> I think we're wanting to prefer "mcdt-no".  Can be fixed on commit.

I've asked myself whether to use - or _, went with _ because that's
the exact name on the manuals (minus the lowercase).

> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

I'm fine if you want to adjust to - on commit.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.