[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules


  • To: Julien Grall <julien@xxxxxxx>
  • From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
  • Date: Tue, 10 May 2022 11:49:15 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e7jKmIRWWUAkDdjY/KhGQD5W+r5PsML83FL4dxiUmks=; b=Fz4cL0j4GBNvQfvsYptEHAIqH6ZdFNmTeUaQtPJH9FGtRwjQoSjqM7iNq9EYHd8PVBmUtDJH9n28jq2WH5qgSeCzKPt13mIScOAaXBFeRT2IP+3NfG5JtP4ss6qbVTobb9kyfpN3clEc4PMH2YHIASEobkY5lMleEWFcLym6eJhBBI0eyXbsr0EMbrjGxyZEdqggHyFZ9j9DZuRcFcZH/omexXpQiPFGPsH41CyLzVn/+VBZAlGbkCCGlOfscWbCOyugGF591gIXD1enAnM04tHLveN/kB9NmrVLNYgUGhH8LJYun7YSW6k3ywUYDN0WBt45VUJfHh9gfyRY3GkLZg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e7jKmIRWWUAkDdjY/KhGQD5W+r5PsML83FL4dxiUmks=; b=Dl2vajc6q1g5NFZwDZo/i2vNdpDwonXTF2oRLXddKrj7K6bl0VaYvjr4CfBAe0nbS/Xu2OJwF8ATbHF5ZjZsAfD1agoOp4YoaGnTFu6iLqhNzXWcARN1a7UixawvI+V4f9T66uMR0VJR3qEVyCusVDqvp5/63SJgfTMoH9dHgd0LyFJIkeFoIqyF5DqJtYvudmGHwlK43cjJDqs3z9peIfwvJ7Q4z0VMuGWUMkBFU3jkGV4CvCl2R7jaSxbB6mheLSA83E0R6BInPw+LCZpqF4MbXufMSVzxkTHwTuLELrMUcwk2G7zUkWKgpMd1x9l6Fw50Kj6IICdKqwb9PZyk8Q==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ALxE5FNwy0+AKLVoat9S+AGIo1vptNCRcfcu8BIFv4OJZ1KW7IoWLqhQyBHUrybmi8RNat0CYd+PzCSCs7NnlO05gBB/174yu0o8f9JNSnlhg4H+0wNic8Q+GzYoYJ8tysktm+hw+FXcMRj+Kqhy8Npsd215E6yDzKG6wbWWn2M6oOMTGKPIpdV6FOOFbHDM8N7pVKWfZvEtAPe5wC5al666T18Q166r3v5B0QNoGyyS+bdqjOFlnSvETFZFL393Ggel2u0STSBOfonWyamxSjv9RzrBVSTWs6ROoQKoirdeEdYQyrdumaC2RCPAdeE4O3Ew+FkY/ZGHv/LJ57Sj7g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=baYjLXh185jWjMTNNJr+MDA7sLn8ZBKake3gT5eROg3TQqMG4/OwwHNCTl+U/clb5L4IBgTzeaN2wbwxNXS8DYFz/6UEvyHGPWpzWdZ3E2I3lKI+UogO0oklGCAlk8gmyJeNzNsL9tMbn7uKHQRP63iqFAdWi1L3p63YpTPipyX60508ZHmVqyCfRnyV8V2UBqSGh78V9a63GSaZs8saorym4AMvJeG2Y8WZlt9k6DlRJX5H+lTOVCzNKO8qRLEWapVDXCQyclsQy8K+rag1oOKVNuz+QEn7z63nOQa3uC0zRrBBYCh5WVeCc+6dJakkbht5DPCxjzV7tmtTNBnaPA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>
  • Delivery-date: Tue, 10 May 2022 11:49:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYWWqn4igAeGv7Uk6q5mD33SrErq0W8JQAgAEkhwA=
  • Thread-topic: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules

Hi

> On 9 May 2022, at 19:22, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi,
> 
> On 26/04/2022 13:38, Bertrand Marquis wrote:
>> diff --git a/xen/arch/arm/include/asm/processor.h 
>> b/xen/arch/arm/include/asm/processor.h
>> index 852b5f3c24..ef37cfa16f 100644
>> --- a/xen/arch/arm/include/asm/processor.h
>> +++ b/xen/arch/arm/include/asm/processor.h
>> @@ -219,9 +219,11 @@
>>                           SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
>>                           SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)
>>  +#ifndef CPPCHECK
> 
> Can you add a comment explaining why you need this check?

Sure, would the following be ok ?
Cppcheck preprocessor is wrongly throwing the error here so disable this check 
for cppcheck runs

> 
> With that:
> 
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
> 

Thanks
Bertrand

> Cheers,
> 
> -- 
> Julien Grall
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.