[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] xen/build: Add cppcheck and cppcheck-html make rules



Hi,

On 26/04/2022 13:38, Bertrand Marquis wrote:
diff --git a/xen/arch/arm/include/asm/processor.h 
b/xen/arch/arm/include/asm/processor.h
index 852b5f3c24..ef37cfa16f 100644
--- a/xen/arch/arm/include/asm/processor.h
+++ b/xen/arch/arm/include/asm/processor.h
@@ -219,9 +219,11 @@
                           SCTLR_Axx_ELx_A    | SCTLR_Axx_ELx_C   |\
                           SCTLR_Axx_ELx_WXN  | SCTLR_Axx_ELx_EE)
+#ifndef CPPCHECK

Can you add a comment explaining why you need this check?

With that:

Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.