[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap
- To: Penny Zheng <Penny.Zheng@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 6 May 2022 08:14:27 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3G2EPdRZbYZXLcg0XbTX+qnuH8xgX3vTMGts2VbuJfs=; b=GRzZmoXyxfbe9v7L7TbNk8tLDst2YaYSkGnUrf/lSvnawBYkdIwfJucfyMBeqX3E2iZweaJqN5sRuAAq5rj7lciB9WT8/YNf01v4oEwyvBv/RX0eQFSjca8uSBQsjlRNQeUVc8M0Jk2ieovqgyJKMOnw3fMtOYjBulLDQ3cwUdzYf7oXhvm7hK4UaaRPO8g3tGsVhLa6yJsf0qXqJl2yGsscNWP2TM8lw0TIJ2AKTeuNbv8EhTWvbG9cT0BRE8Dsjj/IuIVwVbjJ/ueLBoGS9KWLYiNk2c3dUDIjiMlkNGdnoFTeDQWzY4NMJxZ/gG2ahb33q/BWhxfMADAtdw7cNg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JSi7xsyivMEA/FuMg07VONv+uv6dJWwff0C8YHZxISHjEtNuN8rE4Ro1eIBYZsecqydCObiEJwASgcJQ9pY5UUq/fzTwCZmafsnzyYAkRCBXtFWxCer+X17ypaH02zlF5GsG3M/4Jch9FBfs/4c+mCQRH14LpblRLa9Vp7w0Ymj17wPt+r++GJMd9eLcindvjSZEmdXQpIIrQcfC6cRpOuktk70IP+S6dm5GYlpHU5lGqLL6+c5IVVQmeGW4t27yFC+vLVnmv+nFXsJ/lsnETkws3afPoPQjg6F6sdfOdNOElQXbBg1I/zmuVtgb7VlmB5cfNeh+ancmceVbm49FYw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 06 May 2022 06:14:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 06.05.2022 04:59, Penny Zheng wrote:
> Hi jan
>
>> -----Original Message-----
>> From: Jan Beulich <jbeulich@xxxxxxxx>
>> Sent: Thursday, May 5, 2022 10:23 PM
>> To: Penny Zheng <Penny.Zheng@xxxxxxx>
>> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Henry Wang <Henry.Wang@xxxxxxx>;
>> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap
>> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
>> <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
>> devel@xxxxxxxxxxxxxxxxxxxx
>> Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap
>>
>> On 05.05.2022 15:44, Penny Zheng wrote:
>>> I misunderstand what you suggested here, I thought you were suggesting
>>> a way of stub function which could bring some optimization.
>>> The reason I introduced free_staticmem_pages and acquire_reserved_page
>>> here is that we now used them in common code, and if they are not
>>> defined(using stub) on !CONFIG_STATIC_MEMORY, we will have " hidden
>> symbol `xxx' isn't defined " compilation error.
>>
>> This is what I've asked for clarification about: If such errors surface, I'd
>> like to
>> understand why the respective call sites aren't DCE-ed by the compiler.
>>
>
> Because both definition of PGC_reserved and is_domain_using_static_memory are
> not guarded by CONFIG_STATIC_MEMORY in the first place in arm-specific file.
So perhaps that's what wants changing (at least for PGC_reserved)?
Jan
|
