[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Fri, 6 May 2022 02:59:16 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doKwwuTrT5tguvTxwBYs13QeXQqQ9/7oI9wx9CW+Kww=; b=BHIa8Q5GEOQ7wdyCvXdI+r4wV6gI9ZzWQCuWklj8o3Il3upK2VIX1rS5VhY2T8bk8uQrpl2ySxPq/Klc6xkosJOX4+Ub7voThWmxcsJp0ctNUmf/Upinqy5S97K2pSPadGxwfIIz/SCeOR4w9eHseNWfu5o+IvGQvy4sixtD2CoSfXuDikuq0/qOQtQS0SmDgXB7Rq1+h++Ysj5Dczu2/hDYlbTlXmRs05qvjt43cU5FqcwX0u1V/iZsfNLtIQ1NRJxko59GjLQPs5cMtQApg4QBJbQSkrwpj/yxjfmCIgNFI2ohl2LBunP+loPBkiztJYGcM7ULm7FX1ksSQCZNZg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=doKwwuTrT5tguvTxwBYs13QeXQqQ9/7oI9wx9CW+Kww=; b=NI6jK89UhRisb8ZjxmXDwPArL9rwnGZlZzv5XkyEFaCNKv+Mbdp3Gveb7sao7XzArvVDlGfwR/OOODedW9dkbmwvTYjFWsnufn+hhcl2m98NG2jBl7qc/agwkuOJ6zY2AB/T1MTeYF5SJNYX8UHeyVBIP2eIt548OODWUNKyE1zTmdyQVYgDlV5NwVcxVd/gyLr8MPPDmD3V4GaUS7/n4zSCjUuyvKF1LGYJ10+V/AHSEUxUJIU3D0jK/rkRTZXtlqULVfrUqLA4P9lzekKNkdHWFEA09WZ1cJaN805//o7qcoh0ILA2Rj4AjHBHx6iPJsauRFI2cODn1QbjoGXz4g==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dFeD6UxjPW5hpZkbqGRygnO7yskpvf/e3q6QAvjHOmp49hlrTfMdaKdcSKSK2Hgz3KmHen7O98tSNB3qWgg7M6jtG15cvkEqfX4gfrn3nLCwhNk1V34/5zVE42NbAmfby/r7lbaUPAnt6QKzQr+t3G42YqwjrP0vTbzyhRGWkNvskBFpyAQFDimG8t149xrkx99py3v7ZTKxLARB2FZ1vFp5nFxzgdOBS9vwxCantZTs35Qe2T9xA//SWu0HN48Tppn7k2kRBAa9keQU6xoNouj5l2UzyOalANUBy8ppLHuymWEC1bwFVvAHCMHiz87H5u1voC2eRC5xDlQ3Zl8JWg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=muLQIFPgaPXvY5qMMGXJDJyW+TgAryxPSqO+TUPDxemf90dP55sLISdtrluzZ6IZPm6KJII5ASEn/ODrreETwyDIMIqSoty7SOb55Apu0bgAwt39yPT0pJp0wYjcKkyYl6hg1dAObOnIg2FRC6gqwkJetDS8FWJ66z+1svBnp/NOSiVWSH+rijgNHLlW5Lys4p81sh8z0YYjUIJDIp2XYo063AnGJLymq75AYE5GhqD+i9Di1gLtESBnlZHgjw0BMImABBDqMFGxy8zDMwt3XAxj5+lcQO9yafQO7frYVqg256LSmBnnL1xT/QidAmwfU9dm8/mbKSgaLIdCIgXg4w==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Wei Chen <Wei.Chen@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 06 May 2022 02:59:42 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHYWhlFOdBlNRd7J0aYNs5h64D4UK0OxgEAgAEVjwCAABi4gIAAB8rggAAKIYCAAAcaUIAAL5+AgAAR4BCAABRbgIAA0kVw
  • Thread-topic: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap

Hi jan

> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Thursday, May 5, 2022 10:23 PM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>
> Cc: Wei Chen <Wei.Chen@xxxxxxx>; Henry Wang <Henry.Wang@xxxxxxx>;
> Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v3 6/6] xen: retrieve reserved pages on populate_physmap
> 
> On 05.05.2022 15:44, Penny Zheng wrote:
> > I misunderstand what you suggested here, I thought you were suggesting
> > a way of stub function which could bring some optimization.
> > The reason I introduced free_staticmem_pages and acquire_reserved_page
> > here is that we now used them in common code, and if they are not
> > defined(using stub) on !CONFIG_STATIC_MEMORY, we will have " hidden
> symbol `xxx' isn't defined " compilation error.
> 
> This is what I've asked for clarification about: If such errors surface, I'd 
> like to
> understand why the respective call sites aren't DCE-ed by the compiler.
> 

Because both definition of PGC_reserved and is_domain_using_static_memory are
not guarded by CONFIG_STATIC_MEMORY in the first place in arm-specific file.

> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.