[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 30/30] um: Avoid duplicate call to kmsg_dump()
 
- To: akpm@xxxxxxxxxxxxxxxxxxxx,	bhe@xxxxxxxxxx,	pmladek@xxxxxxxx,	kexec@xxxxxxxxxxxxxxxxxxx
 
- From: "Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx>
 
- Date: Wed, 27 Apr 2022 19:49:24 -0300
 
- Cc: linux-kernel@xxxxxxxxxxxxxxx,	bcm-kernel-feedback-list@xxxxxxxxxxxx,	coresight@xxxxxxxxxxxxxxxx,	linuxppc-dev@xxxxxxxxxxxxxxxx,	linux-alpha@xxxxxxxxxxxxxxx,	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx,	linux-edac@xxxxxxxxxxxxxxx,	linux-hyperv@xxxxxxxxxxxxxxx,	linux-leds@xxxxxxxxxxxxxxx,	linux-mips@xxxxxxxxxxxxxxx,	linux-parisc@xxxxxxxxxxxxxxx,	linux-pm@xxxxxxxxxxxxxxx,	linux-remoteproc@xxxxxxxxxxxxxxx,	linux-s390@xxxxxxxxxxxxxxx,	linux-tegra@xxxxxxxxxxxxxxx,	linux-um@xxxxxxxxxxxxxxxxxxx,	linux-xtensa@xxxxxxxxxxxxxxxx,	netdev@xxxxxxxxxxxxxxx,	openipmi-developer@xxxxxxxxxxxxxxxxxxxxx,	rcu@xxxxxxxxxxxxxxx,	sparclinux@xxxxxxxxxxxxxxx,	xen-devel@xxxxxxxxxxxxxxxxxxxx,	x86@xxxxxxxxxx,	kernel-dev@xxxxxxxxxx,	gpiccoli@xxxxxxxxxx,	kernel@xxxxxxxxxxxx,	halves@xxxxxxxxxxxxx,	fabiomirmar@xxxxxxxxx,	alejandro.j.jimenez@xxxxxxxxxx,	andriy.shevchenko@xxxxxxxxxxxxxxx,	arnd@xxxxxxxx,	bp@xxxxxxxxx,	corbet@xxxxxxx,	d.hatayama@xxxxxxxxxxxxxx,	dave.hansen@xxxxxxxxxxxxxxx,	dyoung@xxxxxxxxxx,	feng.tang@xxxxxxxxx,	gregkh@xxxxxxxxxxxxxxxxxxx,	mikelley@xxxxxxxxxxxxx,	hidehiro.kawai.ez@xxxxxxxxxxx,	jgross@xxxxxxxx,	john.ogness@xxxxxxxxxxxxx,	keescook@xxxxxxxxxxxx,	luto@xxxxxxxxxx,	mhiramat@xxxxxxxxxx,	mingo@xxxxxxxxxx,	paulmck@xxxxxxxxxx,	peterz@xxxxxxxxxxxxx,	rostedt@xxxxxxxxxxx,	senozhatsky@xxxxxxxxxxxx,	stern@xxxxxxxxxxxxxxxxxxx,	tglx@xxxxxxxxxxxxx,	vgoyal@xxxxxxxxxx,	vkuznets@xxxxxxxxxx,	will@xxxxxxxxxx,	Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>,	Johannes Berg <johannes@xxxxxxxxxxxxxxxx>,	Richard Weinberger <richard@xxxxxx>
 
- Delivery-date: Wed, 27 Apr 2022 23:03:31 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
 
 
Currently the panic notifier panic_exit() calls kmsg_dump() and
some console flushing routines - this makes sense since such
panic notifier exits UserMode Linux and never returns.
Happens that after a panic refactor, kmsg_dump() is now always
called *before* the pre_reboot list of panic notifiers, in which
panic_exit() belongs, leading to a double call situation.
This patch changes that by removing such call from the panic
notifier, but leaving the console flushing calls since the
pre_reboot list still runs before console flushing on panic().
Cc: Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>
Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
Cc: Richard Weinberger <richard@xxxxxx>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@xxxxxxxxxx>
---
 arch/um/kernel/um_arch.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c
index fc6e443299da..651310e3e86f 100644
--- a/arch/um/kernel/um_arch.c
+++ b/arch/um/kernel/um_arch.c
@@ -241,7 +241,6 @@ static void __init uml_postsetup(void)
 static int panic_exit(struct notifier_block *self, unsigned long unused1,
                      void *unused2)
 {
-       kmsg_dump(KMSG_DUMP_PANIC);
        bust_spinlocks(1);
        bust_spinlocks(0);
        uml_exitcode = 1;
-- 
2.36.0
 
    
     |