[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 25 Apr 2022 15:44:49 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghY+xzaSACVfn+rBM7XU56+JSQXJZR3ojZ70fLF589w=; b=b5bDtJP+v1AcWaNMEQFkqrhBQZMZDOjkhAsKFMugudXPINoHsdQDpLOtNjQp0izOIeOENyelLoZsBX1W2d64ScVr2bU1SYVjGf2wDZDdz+zM/D/ejM1V8yWFLQD5C5r6R6sHGsEmsgk+BdaNzSv6SrmVgzGyCPKPP395RuiG4+t4Bw4f+7mzbzdSL7jN72YQsisvdXXQMFYF4M2ylSAGqVGZB7Fk37cP0M8pliZW63V9zYAudmI4FBqtxuWAdDtRF6lJ2oSGZQ2OW/UpSlEfe8Dx+AaUfv1EfIpyJug6RLR+fl29C5RZTL2FgoOy9XVifb7we36s2F6VxGvx4f+neQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hWCAVO7jZrtVX5t3waFgag+HDxFvcWeizvRhEk6bDAJxtcFkVdKIshZCun8ZcDqtKJ7fC5dM3RNaL6EmP/2IjYIixQmIbkNNbaReIBZMP1UAwDLRXaC0xRAjQL/0O/jlyraOUBil3fc0MDoIu0TFlXTgTLH8X7KzIB8Pu9zX4zD6CnlH3CbtPb4ZzktHBWi6sH7VuLX0YVn53YxjJAYj2gTPVB70B76evUcJ1Rh0A9Ht+glM07LfTPodi6HgIIl7CfQ0e6TZWcwXC8DNyq4j5w3ALnyaC++1lHuM7QZeAyhdsB+sevrWnX491v5Oipfhg8/H3Y53BgyJn6sDV0rslw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, David Vrabel <dvrabel@xxxxxxxxxxxx>, David Vrabel <dvrabel@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 25 Apr 2022 13:45:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.04.2022 15:43, Julien Grall wrote:
> On 25/04/2022 14:37, Jan Beulich wrote:
>> On 25.04.2022 15:34, Julien Grall wrote:
>>> On 25/04/2022 14:28, David Vrabel wrote:
>>>> --- a/xen/common/page_alloc.c
>>>> +++ b/xen/common/page_alloc.c
>>>> @@ -162,6 +162,13 @@
>>>> static char __initdata opt_badpage[100] = "";
>>>> string_param("badpage", opt_badpage);
>>>>
>>>> +/*
>>>> + * Heap allocations may need TLB flushes which require IRQs to be
>>>
>>> The comment needs to be updated to reflect the fact that at least Arm
>>> doesn't use IPI to flush TLBs.
>>
>> I thought the use of "may" was satisfying your earlier request?
>
> Maybe I read wrongly this comment... To me, anything after 'which' is
> optional (it is a non-defining clause) and describe how the TLB flushes
> works. So the 'may' here is referring to the possibility to use flush TLB.
Oh, so you'd like to have a 2nd "may" inserted later in the sentence.
Jan
|
