[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4] page_alloc: assert IRQs are enabled in heap alloc/free
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 25 Apr 2022 15:37:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RSsxJi9LYlPJl+IIMTs5uDaDxpOJHdoiSIxtw0NZvLI=; b=finOw7y2zHliiZogVk1iEjGTkXx5fIRyKK2MzcNDsfvaTIqTTQw7TSsPysjo2/pBODWi7588Tzg0i7/K3uLhDe6Fe+p5QADIHkuZ+l5qcw0L/rukTTeGLX9STkDzCWkCmTjXv/mdxM55oRJsKIm0/cF57q0dRIaplc4DI0d+dndqCtlTa+ZvDXkeVNo8emMaJyyHS3i4MPm+ry7eqYSHW6PXh0Nsm58DQG/UyrIf1eN9DgLt5/Xuh3QkQ+10PdsnSzzcp/CCtY1a7Ur22ziodUmXP1R9p8cPn1YxdfMFIOGtjldbiPq97PZuxM6+7CbJ7kvbkzdhPqS8p2bFl3sH4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OX6d23fwd/V3C+QSd2afj/UyNYQnC+i723y2FqPjGeUR/dmaRlkwW4TK5gmotiC8xYhx/+SV72Io4yMcKa7a1Qmb/lXtHhzyWv0oXQK/qm/JML8PsIzrSzBAFRLkZSt5mLYVxsgopmzsH4qG5m/xNeN9Nv1jUT605mmu7zHdc8QBoGHcsh17+Fbd5YZBuHGL8xbJIvEJC/DUXgtfAinpUKg4ERVeR53FskA+Ctqf5CV5sfKJK++mqit2JP5sYac1FHjSxnNiO4sN/QGQGGD4yhYLC2z6WRH5/SZUGpIpf0G2Y+O65vbzKSMrKE5fkSMzyI4PcL2n3dr/sP2NTG8Gag==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, David Vrabel <dvrabel@xxxxxxxxxxxx>, David Vrabel <dvrabel@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 25 Apr 2022 13:37:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.04.2022 15:34, Julien Grall wrote:
> On 25/04/2022 14:28, David Vrabel wrote:
>> --- a/xen/common/page_alloc.c
>> +++ b/xen/common/page_alloc.c
>> @@ -162,6 +162,13 @@
>> static char __initdata opt_badpage[100] = "";
>> string_param("badpage", opt_badpage);
>>
>> +/*
>> + * Heap allocations may need TLB flushes which require IRQs to be
>
> The comment needs to be updated to reflect the fact that at least Arm
> doesn't use IPI to flush TLBs.
I thought the use of "may" was satisfying your earlier request?
Jan
|
