[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 3/6] x86/gdbsx: Move domain_pause_for_debugger() into gdbsx


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 21 Apr 2022 15:08:04 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m3Ll8XXoAgebmEaBxUAzSYZ46MdXqYrYM0ejhfGT9/4=; b=ghaNz59EDWKuutuHuofg/VrGnPvk5o6XfAySzyI7D+dLFm5Tq34ltlASWGhnpg+YRUKn2W971m7uPR3NycX95ndILPbAOS9pIyLmaXTkprwSB+Zd/rAUv5SSkk0A6EPBhkou0YTRG+3PRU0kwGshQ3uIyQAgLzuHHrvdlzwWL5trEQhSk1Y0xnf8LuPzvwhBxLEfv1QAqmuXamzfOd8WtseCruor+uqNMBy0CspuS8xvrBnu7/KmKABbbmlOKxlrm1gjpnApRRWFHVrj3raxxCsEebsuich5dz1dO5iDemqQXpLPQK+qRO3/9FC8BOrj/H4CaYTn3NhzxQRRvAb6Pw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F8YyXXiDs1vFLJcMC4rI2Fub7Ly9HcwnxcUGd4jZLDoNpax3Mm4QQHLouv4OrBKf5DO+VzXLhs/pqUQe7CuuYw5NyTYMs8GdesT7ID0PEXNewT5FkyjaOXBo914bz7CySJX2ts53A/BxMPl2n9DjRl4/0+tjwPdQqwaT+Rv9N1XMEnTn2Hsb5KOMOX7rChKnvwXj9u9sYGjHLT7cmo9CoJbeEzm8GwsTXr4vfj8H1WZdTCvOamNhWLRFxPVgyYwbN4v8F6yn+E1V/3MOv16HRrFtvFSkkFINm/oA+4T+d9GX/SEvypHHKFRIMQug+tAYJYIpZ4SiSYeUgTHUM4Qw9w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 21 Apr 2022 13:08:16 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.04.2022 16:13, Andrew Cooper wrote:
> domain_pause_for_debugger() is guest debugging (CONFIG_GDBSX) not host
> debugging (CONFIG_CRASH_DEBUG).
> 
> Move it into the new gdbsx.c to drop the (incorrect) ifdefary, and provide a
> static inline in the !CONFIG_GDBSX case so callers can optimise away
> everything rather than having to emit a call to an empty function.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.