[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/6] x86/gdbsx: Rename debug.c to gdbsx.c
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 21 Apr 2022 15:06:26 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tepNA3z5icaKcddPsneOrUEpl8pzhfueXNqcqLddl+k=; b=W1bzwVT6/V0iv0lnop5ko7MtH+JXsoWxMoJXdqkmnNSxiAUiiSUsaa+ceIJ1ugARnjtcdGdTYiWH2pHz/W3vlvNTP00ZpzAMGvZw2IBNfC6dmrIiqjb9Jt08kx9tFZO8lfsay2IqSmAVmDtkSRGzClZt2qwCwcUnlkrXuxZxRZxmNyc5XTnCykZNVeBpiexQ88vPeO5QXZUp0QKgJ6ylfE12o3hJNN4zneoAqE+S9L2JelpvfbqQt9LZlmJXT734PlMxvlQK6iAeDWme7lNOpc9TQx/eioyjb+XlB4iNtZ/COK+kSz/uongeMOiBZbvhVF5BIDmlhMBGyazc6NhWxw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jFFkGIwjWLefrBmOqaF4fvC3XrWWJisSKepofYaqWCBXXnDk929EKg4Ks2IvWyG9Em4zrBVT/1q3csRc0sVJUG/cteRt82rLkKdNao2/p7iiBAmSmA+RJxXUOEoavubiT7PY/jALKy/xQzfrpbh1J3hnZKko2zLhih+vIjLgE5zV08VyGoFr995RGRmfryonrWz67yJqVDxoGJG1iiCn5jW/gqwF58z6dVe1WGC8cWK1e9vBOmdyL1vTeP0xWWBti4GLbIxlRFEOO3xDWOF7fCivGvt2YPXkxqkugrwMQDqpMyRElhTuRzFecaFlpxL9V8J+IsYXKRhvzCBfYtc6iA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 21 Apr 2022 13:06:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.04.2022 16:13, Andrew Cooper wrote:
> From: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
>
> debug.c contains only dbg_rw_mem(). Rename it to gdbsx.c.
>
> Move gdbsx_guest_mem_io(), and the prior setup of iop->remain, from domctl.c
> to gdbsx.c, merging it with dbg_rw_mem().
>
> Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> The semantics are rather broken. XEN_DOMCTL_gdbsx_guestmemio only sets
> copyback when there's nothing to copy back, and skips copying back in the
> -EFAULT case when the iop->remain field is relevant. Furthermore, it can be
> asked to move up to 4GB in one go, with no continuability whatsoever.
The last point perhaps isn't overly much of a problem for this specific
operation.
Jan
|
