[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
 
- To: Christoph Hellwig <hch@xxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
 
- From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
 
- Date: Fri, 15 Apr 2022 05:51:29 +0000
 
- Accept-language: en-US
 
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none
 
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gg8hdgNEhj02MY/XmMdpyN8wb87wt0DFAivKrNj4n08=; b=jvguEBMxycXbMCw6KPaqOa4VrhjKN9V7qiaNFWMwsqbfLjBYgQENWNFsj6ZMi2P1fT4Y6agiBkPTFtUyhBFWuWrE1bi3V3PiwpdSAbk7MIssOAqWRLZBqXaVnNjDHGFfH8hAPV0RdufDizG/sjrdB09LBoYh0Osnq3kDjgv6riaMxfMPXNK6G8tBGlEhIgqPS363DChPE3g2Ef/K/nllIjxcrUEv8mvcrnkpP12p57t+rLO/YKzFlvFG3ePYKKIZiKxwqC5GQNEmeyTsE1Gwf+9yU/ydFjpva9A8DRNAATmD1DdZXXMPQX/yra+sryYPqCC5OHH3H0w6sIG4CGt3Cg==
 
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O77Ekaajc81OAFOi95GlPR4qcqaBkysRHsJ43vFj1+j3H3zLtSUSqZUgbck05+m4DSy9MMrse7WZocMAwHtUfg3UyWBUfse+6nx1sGW0+7mq0XASog4m1XVFgjPp8rdSIM5tx5IbNA7UhqYvbNZ4b3pKlQA/BdrMKRbQ5+gd50O7Wvq5adewagI0+2R15UvKZIwSieXyV93tgXxuyTqGlUcEjVpHRvyBWPvcI81M64098L5mQr8udbKzqt8nEmImFpxC3DCVIYhgVhkWidXrMpzZfmRiQljqlO9/VVQPqSQQs61a63GpccjAjXny4IGLF2wUMT6Se6SpFO2haEIx7w==
 
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com;
 
- Cc: "dm-devel@xxxxxxxxxx" <dm-devel@xxxxxxxxxx>, "linux-xfs@xxxxxxxxxxxxxxx"	<linux-xfs@xxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx"	<linux-fsdevel@xxxxxxxxxxxxxxx>, "linux-um@xxxxxxxxxxxxxxxxxxx"	<linux-um@xxxxxxxxxxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx"	<linux-block@xxxxxxxxxxxxxxx>, "drbd-dev@xxxxxxxxxxxxxxxx"	<drbd-dev@xxxxxxxxxxxxxxxx>, "nbd@xxxxxxxxxxxxxxxx" <nbd@xxxxxxxxxxxxxxxx>,	"ceph-devel@xxxxxxxxxxxxxxx" <ceph-devel@xxxxxxxxxxxxxxx>,	"virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx"	<virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx"	<xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-bcache@xxxxxxxxxxxxxxx"	<linux-bcache@xxxxxxxxxxxxxxx>, "linux-raid@xxxxxxxxxxxxxxx"	<linux-raid@xxxxxxxxxxxxxxx>, "linux-mmc@xxxxxxxxxxxxxxx"	<linux-mmc@xxxxxxxxxxxxxxx>, "linux-mtd@xxxxxxxxxxxxxxxxxxx"	<linux-mtd@xxxxxxxxxxxxxxxxxxx>, "linux-nvme@xxxxxxxxxxxxxxxxxxx"	<linux-nvme@xxxxxxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx"	<linux-s390@xxxxxxxxxxxxxxx>, "linux-scsi@xxxxxxxxxxxxxxx"	<linux-scsi@xxxxxxxxxxxxxxx>, "target-devel@xxxxxxxxxxxxxxx"	<target-devel@xxxxxxxxxxxxxxx>, "linux-btrfs@xxxxxxxxxxxxxxx"	<linux-btrfs@xxxxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx"	<linux-ext4@xxxxxxxxxxxxxxx>, "linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx"	<linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx>, "cluster-devel@xxxxxxxxxx"	<cluster-devel@xxxxxxxxxx>, "jfs-discussion@xxxxxxxxxxxxxxxxxxxxx"	<jfs-discussion@xxxxxxxxxxxxxxxxxxxxx>, "linux-nilfs@xxxxxxxxxxxxxxx"	<linux-nilfs@xxxxxxxxxxxxxxx>, "ntfs3@xxxxxxxxxxxxxxx"	<ntfs3@xxxxxxxxxxxxxxx>, "ocfs2-devel@xxxxxxxxxxxxxx"	<ocfs2-devel@xxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>,	"Martin K . Petersen" <martin.petersen@xxxxxxxxxx>,	Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx>,	Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx>, Jaegeuk Kim	<jaegeuk@xxxxxxxxxx>, Coly Li <colyli@xxxxxxx>, David Sterba	<dsterba@xxxxxxxx>
 
- Delivery-date: Fri, 15 Apr 2022 05:51:36 +0000
 
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
 
- Thread-index: AQHYUITx2Wbm58EJ9UyANBYH5JqbHKzweKgA
 
- Thread-topic: [PATCH 26/27] block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD
 
 
 
On 4/14/22 21:52, Christoph Hellwig wrote:
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint.  Fully split the limits and helper
> infrastructure to make the separation more clear.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx> [drbd]
> Acked-by: Ryusuke Konishi <konishi.ryusuke@xxxxxxxxx> [nifs2]
> Acked-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> [f2fs]
> Acked-by: Coly Li <colyli@xxxxxxx> [bcache]
> Acked-by: David Sterba <dsterba@xxxxxxxx> [btrfs]
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>
-ck
 
 
    
     |