Re: [PATCH 24/27] block: remove QUEUE_FLAG_DISCARD

[Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>]

On 4/14/22 21:52, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
> 
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by default,
> even if the default stacking rules would allow for it.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Acked-by: Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx> [drbd]
> Acked-by: Jan Höppner <hoeppner@xxxxxxxxxxxxx> [s390]
> Acked-by: Coly Li <colyli@xxxxxxx> [bcache]
> Acked-by: David Sterba <dsterba@xxxxxxxx> [btrfs]
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck