Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi Julien,

On 08.04.2022 19:58, Julien Grall wrote:
> Hi Michal,
> 
> On 05/04/2022 10:16, Michal Orzel wrote:
>>   #if defined(BUILD_ID)
>> @@ -109,12 +104,7 @@ SECTIONS
>>          *(.data.schedulers)
>>          __end_schedulers_array = .;
>>   -#ifdef CONFIG_HYPFS
>> -       . = ALIGN(8);
> 
> This will be replaced with POINTER_ALIGN which is 4-byte on Arm32. AFAICT, 
> there are no 64-bit value used in struct param_hypfs. So it should be fine.
> 
> That said, I think this is worth mentioning in the commit message.
> 
> The rest of this patch looks good to me.
> 
> Cheers,
> 
Ok, I will update the commit and repush the series.

Thanks,
Michal