[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros
- To: Michal Orzel <michal.orzel@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Julien Grall <julien@xxxxxxx>
- Date: Fri, 8 Apr 2022 18:58:41 +0100
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 08 Apr 2022 17:58:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Michal,
On 05/04/2022 10:16, Michal Orzel wrote:
#if defined(BUILD_ID)
@@ -109,12 +104,7 @@ SECTIONS
*(.data.schedulers)
__end_schedulers_array = .;
-#ifdef CONFIG_HYPFS
- . = ALIGN(8);
This will be replaced with POINTER_ALIGN which is 4-byte on Arm32.
AFAICT, there are no 64-bit value used in struct param_hypfs. So it
should be fine.
That said, I think this is worth mentioning in the commit message.
The rest of this patch looks good to me.
Cheers,
--
Julien Grall
|
