[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV and HVM parts


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 8 Apr 2022 12:55:18 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dPIji40V/ZjD/odqpInMrAyzokkt4ybmnCbHG3Pc8vI=; b=lA6XuJkZbptCTch7+SWzsLbDqirUc3mlU9aVMbCOjSYkFlachnX8fOxQ6kE2DGy/dgbmufKaCknpDLJrOHjDdQunz5lo0i2IV8ZD8Sdhlm1AHyG80msij56qMq+ah5xLii7R/7+KJnLpLf6WRmrGMwq0U9YhSVj5isjwEIdaX0K5fvOLDGDI4M305nczFimVBMA/GycNESTAlXQwKcyUPPgNJevb20MZvfeC02YQKbxf9NHUrUWlZNRBPNpdW32oRDIABDUBCQczGGACky8QtQlQVhDCEmIsX2f2J7cgaRGEY3Ku2Xg5P7jcdyOQ/E/T5STeD0z44LuuXw/zpxITrA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AFEy1xJU4Pw1e1RN+UoMsCX3xUMab1qqy8jqj8+Sgx3gIqsmnKm2CY8vmGTZhGB71w+ocQ8fz5z0dIogccbOqw7KsIjq55dzBcY2/Nr4AEWcXP6phvunJqUzN4bfC3zyXsfFEc0bkYLCegZBg4NUpxCCvj+cBqjUeQynQthBWhi8n3jnYbVgceZoWEGAsPGfOLac+3nteVqNJNIFlOVCjmLXdHMKt1bdCDEluWgRGm2oM8tQ7F1fLtDSwAvbrlRGHNtri7DzNbL2YCJzhpXmraDLTglG2wqityYhNObL26z78bXf10YNqdAhSvxKLguSL4fnZ3yan3bpy7ySr9YssQ==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Fri, 08 Apr 2022 10:55:37 +0000
  • Ironport-data: A9a23:1GFykKjtnmJEBjgxyX9ut1HFX161ehAKZh0ujC45NGQN5FlHY01je htvWzyHP6uIMGHzKdlzaoi+/E4B7ZWAnNZhTldqpC0xEyMb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M78wIFqtQw24LhX1vd4 YqaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YRVxZ7f0x7Reb0AbKwB+MYAc/YPjIkHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bkmtnwjzDS+4vXLjIQrnQ5M8e1zA17ixLNaiOP JdEMWQ/BPjGSxtoEUUNLJM3peepjGKlIi9gpUCfvqVitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzRGhgHMPSPxDzD9Wij7sfNly7mXIMZFJWj6+VnxlaUwwQ7GBAQEFe2v/S9okq/QM5Eb VwZ/DI0qqo//1DtScPyNyBUu1bd4ERaAYAJVbRntkfdkcI4/jp1GEAWFmdbUIN29/NvBgQL1 lOkxdbVIT9W5ej9pW2myp+Yqja7OC4wJGAEZDMZQQZt3+QPsL3fnTqUEI89TffdYsndXGipn mvU9HRWa6A715Zj6kmtwbzQb9tATLDtRxV92AjYV3nNAuhRNN/8PNzABbQ2AJ99wGelorup4 SBsdyu2trlm4XSxeMqlGrhl8FaBvavtDdEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib Sf74F0NtcUDYSb6MvAuOupd7vjGK4C6SLwJsdiOMLJzjmVZLlfbrEmCm2bOt4wSrKTcuf5mY srKGSpdJX0bFb5m3FKLqxQ1itcWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8riq85cHKbPZelMO9aNII6a5/I7NsrdNxsx9vuzJ4 mu8Sglfzl/+jmfAMgKEdjZob7aHYHq1hStT0fAEVbpw50UeXA==
  • Ironport-hdrordr: A9a23:YpTOMaw/a686HeoPCr3HKrPwIr1zdoMgy1knxilNoH1uHvBw8v rEoB1173DJYVoqNk3I++rhBEDwexLhHPdOiOF6UItKNzOW21dAQrsSiLfK8nnNHDD/6/4Y9Y oISdkbNDQoNykZsfrH
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Wed, Feb 23, 2022 at 04:59:42PM +0100, Jan Beulich wrote:
> ..., moving the former into the new physmap.c. Also call the new
> functions directly from arch_iommu_hwdom_init() and
> vpci_make_msix_hole(), as the PV/HVM split is explicit there.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Just one comment below, which can also be taken care in a followup
patch if you agree.

> ---
> v2: Change arch_iommu_hwdom_init() and vpci_make_msix_hole().
> 
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1473,12 +1473,9 @@ static int clear_mmio_p2m_entry(struct d
>      return rc;
>  }
>  
> -#endif /* CONFIG_HVM */
> -
> -int set_identity_p2m_entry(struct domain *d, unsigned long gfn_l,
> +int p2m_add_identity_entry(struct domain *d, unsigned long gfn_l,

I guess switching the gfn_l parameter to be gfn_t gfn, and then
defining:

unsigned long gfn_l = gfn_x(gfn);

Was too much churn?

(this is just so that the exposed interface for p2m_add_identity_entry
is cleaner).

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.