[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 04/14] x86/mm: split set_identity_p2m_entry() into PV and HVM parts


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 6 Apr 2022 16:52:06 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EXxMUPdjJ0cPh9pY6piCGH82AFpiP8wrG9npPLLZqik=; b=Tqb7TcikpFANGQjiy+PWMAf9WSRDiGGWu8H14jgVtoq7VB3C0YQfQ9J9qmHzADGWfufzn5GBrGLcg3djjpTH6pZUfOLFJvJLJ6KajXON2/H1CNaCy/zN08hO/0DBFKOq+htkCZCgwG4iZWAb9zUT2LLQLUEWWg4jdjdfw9RV5kw5aZBbjXbqz9ZjdZ88qdDspS2rCEp9X8LgNYk42J1AMX3HlTPnnQ3nXSoFwDhXx+gQz59yXvJM3GT3e/2+G572jRhDbepiN8OXUv9B849Gkf6pUvot1bl0w/VcSu/F6ZpB2z8skdc2MDIFfYFzAFWN3PpJ2Egp+cjn9GuqJGCCxg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8X08Sh1wTz1cfGCirosAnwvxguMDIoKSnEirXWqeR1JvnZ0V9cseq5sbjPeNYuAEVffN80ObkAk0Jw4PBABryveVno6rRcCG+simshaWvDyAJa/7RGFMpZOv+XiR8ON9iCsJmxkwpb6+FaVotl4tKK9sB7kooTuVOHU3HYnKf8m2QatFP3hk4Z/usqhgxPIBfnnsJ/9NR6R82tEiOnSc4YE0AOqyyJ8AamReGh18P0E6XFi4w69NWvUdmrKIKQG4BTVprxfQni3HMj+fwj7CouH/4427re1cZTIDezZAONm/KLHXV4mhaMT/Ero8PxL29f5dOnagWPvuURN3/+a1g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 06 Apr 2022 14:52:22 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 23.02.2022 16:59, Jan Beulich wrote:
> ..., moving the former into the new physmap.c. Also call the new
> functions directly from arch_iommu_hwdom_init() and
> vpci_make_msix_hole(), as the PV/HVM split is explicit there.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

May I ask for an ack on the vPCI change here?

> --- a/xen/drivers/vpci/msix.c
> +++ b/xen/drivers/vpci/msix.c
> @@ -409,7 +409,7 @@ int vpci_make_msix_hole(const struct pci
>              case p2m_mmio_direct:
>                  if ( mfn_x(mfn) == start )
>                  {
> -                    clear_identity_p2m_entry(d, start);
> +                    p2m_remove_identity_entry(d, start);
>                      break;
>                  }
>                  /* fallthrough. */

Thanks, Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.