[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH early-RFC 1/5] xen/arm: Clean-up the memory layout
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 17 Mar 2022 15:23:55 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arA262akJOhR5cpoO8ioizIXVSnC6SxV5IPxJVVwHuY=; b=ObsB3eYjjn2HaCLBDlNovJcYXYXJlJZsEPBbppR6zyjHy9ksl5tWG6LfFjWJ+WYCoFtdbhGF0+sted9zps5EyuEebHbRqLadoctDnPsSC88JrUH9Sa84BrB+slBvZfB2UxDT0F7AYej24EZE8sxVIYOGmuVKBQ3fvLMYSicx2gyWlgivXUWQ7V9SIh8Oo52fDmH27diFIvcq7zS8ikpjc7vHaDp3LEf/kl4GYncgOnPBqWnfg6qAv2wj3sn1zYh8JqBp3e4wxNGeAuJYduWdd9vfXQo8PY+dIGahVuWkNzB8qrLYaRFhLuVyMr4XlleeSdkck++E4cljJ7JdbETTDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8SLaUzkbyobY3s1j8I4+nSh9xNSi/bexxOgatIULyfmPFIwQimfUNYC6FRBTi+nqDPqfYMTbXm6TpmMC11SjZ0iKdN/3IsscOQ9tGQlibWWGXOVdZoytphBYaYiGXPDbCnSJvcdmL4JbdwtkfsQAkQyh8Rez4htpc5KimC8ZiDFCRf92hqdzlB94MhuWG6tNouJq7QC5B5FM2Baqt5gFH3K19JDkGN4arNcyquBUEyABU0K8viGBE5HV73S0qA58WzS/NOwhxwMNewjHaoAxwlp/U9lAUhgz6P88A/YLOA13EC04uTjlwQsVdpZcx7iV/0O5CMaObcD/Vc25txxMA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "marco.solieri@xxxxxxxxxxxxxxx" <marco.solieri@xxxxxxxxxxxxxxx>, "lucmiccio@xxxxxxxxx" <lucmiccio@xxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 17 Mar 2022 15:24:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYM6fgzbIssM9RMEi7y17EBtCCCazDvrYA
- Thread-topic: [PATCH early-RFC 1/5] xen/arm: Clean-up the memory layout
Hi Julien,
> On 9 Mar 2022, at 11:20, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> In a follow-up patch, the base address for the common mappings will
> vary between arm32 and arm64. To avoid any duplication, define
> every mapping in the common region from the previous one.
>
> Take the opportunity to add mising *_SIZE for some mappings.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Changes looks ok to me so:
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Only one question after.
>
> ---
>
> After the next patch, the term "common" will sound strange because
> the base address is different. Any better suggestion?
MAPPING_VIRT_START ?
Or space maybe..
> ---
> xen/arch/arm/include/asm/config.h | 24 +++++++++++++++++-------
> 1 file changed, 17 insertions(+), 7 deletions(-)
>
> diff --git a/xen/arch/arm/include/asm/config.h
> b/xen/arch/arm/include/asm/config.h
> index aedb586c8d27..5db28a8dbd56 100644
> --- a/xen/arch/arm/include/asm/config.h
> +++ b/xen/arch/arm/include/asm/config.h
> @@ -107,16 +107,26 @@
> * Unused
> */
>
> -#define XEN_VIRT_START _AT(vaddr_t,0x00200000)
> -#define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE)
> +#define COMMON_VIRT_START _AT(vaddr_t, 0)
>
> -#define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000)
> -#define BOOT_FDT_SLOT_SIZE MB(4)
> -#define BOOT_FDT_VIRT_END (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE)
> +#define XEN_VIRT_START (COMMON_VIRT_START + MB(2))
> +#define XEN_SLOT_SIZE MB(2)
I know this is not modified by your patch, but any idea why SLOT is used here ?
XEN_VIRT_SIZE would sound a bit more logic.
Cheers
Bertrand
|
