[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hvm: Include interruptibility state in hvm_hw_cpu
- To: Tamas K Lengyel <tamas.k.lengyel@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Mar 2022 16:06:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=anzT11GYrwgbhbX71TOI2rhQQvlWwAjT9qS2k6DqxY8=; b=F84e6380vdYyAS0d1JgEona6p6Rib0m6H01IYo0cNF2MQ9wQlLf09xROaqZ6CM5mYSQtjK5AWMWe1boXHfyY0wut9EldLW37iqV9yKk0s+367y9Mpn2LthuW/kunaNAT1Rp9M5t8WEHuj7F3VN7V3li29vuJic+SN1DYm5p+kDgiIQUQCkFE2lFgCSF/PwygxI5s3eI987UWeYJkY3/ygb2p1fzJupWqxc01SnIGrhKuSEC/69LUsvfC4G+zRkJskR/VsG9eYZLUOblWeoBRKUl65ft63PKoOYFJGIvkjIhsJxZDeediF8lGBzJoui0PHqhIULalwzC9n3f5T72Fxw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KTTcyxrGeUTdrRKmh6mqDU8B+Z4A+VZaQZ9EXncoVpg34EXj/9vExAcAMXtObBerw4DyjdNNEs7kntoqlUVREc98tLXejt4S9PoTCKREiiAtNjDbCJSsujQQebchvJcyB5pQqI0MyVxGpOCu/0HeXPXyenARbb4DXCTzkwNmE9lONRS5rgxMg6RmBfYTWVH2DIPKkJP311GpNLIYBllqONEeclyUzsGtaLpJEVmqEZUV5kFTzewuEGcV4gx1gXXoad15Zz4G/ROENAFBB9SkbFbmrFx5j1gRZWuVdu85R//z1g1P4Sa9EYvtAp/LLS+KWh/GqFUsRzPHBjX+19esOg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Tamas K Lengyel <tamas.lengyel@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Mar 2022 15:06:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.03.2022 15:43, Tamas K Lengyel wrote:
> On Thu, Mar 17, 2022 at 9:56 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 10.03.2022 19:44, Tamas K Lengyel wrote:
>>> @@ -1155,6 +1154,8 @@ static int cf_check hvm_load_cpu_ctxt(struct domain
>>> *d, hvm_domain_context_t *h)
>>> v->arch.dr6 = ctxt.dr6;
>>> v->arch.dr7 = ctxt.dr7;
>>>
>>> + hvm_set_interrupt_shadow(v, ctxt.interruptibility_info);
>>
>> Setting reserved bits as well as certain combinations of bits will
>> cause VM entry to fail. I think it would be nice to report this as
>> an error here rather than waiting for the VM entry failure.
>
> Not sure if this would be the right spot to do that since that's all
> VMX specific and this is the common hvm code.
Well, it would be the VMX hook to do the checking, with an error
propagated back here.
Jan
|