[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>
- From: Edwin Torok <edvin.torok@xxxxxxxxxx>
- Date: Fri, 25 Feb 2022 16:34:23 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=txgGUiJ+6nBlTCNx2uw2Lxue+ffy4vVAQ9yyLvyT3Yc=; b=ZVs6Y+GCKAX5FbheY9NngBVwiodEWn2SfnXhYT333TCVY6+zYug08RCWmbhzQpw4j0KvG0vD8rUtliGTEtRk31U/y9/xWN6enzNTzhPfQuw4vVi2aREtirRuVkEzq8h5d4H98PUIIoqa1K5W5Gl6dn6gvghWGULMgdSwJg2USye/RNksk/BxfXpM2BcrdCafOLHjJcZoiDFJm00394TAQgXCs1J/xnicHbM2QlNouisf/ltCZfu7rA7EtwRTmnRaiJkOx2zrq4xyZA6a1iOj4sN36paHRis1VLrGHVqT6eZMT7pS8OKEMvQ51tDnsrwIaTznRAxh0HvIYsG1jPmlHA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bo6zoQ+3srPQIW/kgi3m+qsxAIkFo8BYoRQIhvizGqPE7K7479kTqWh65cUEJBh4c+fc32HB1/Fqriur1HYi2rteIJo0otdQR+VFTRb0TNhEPDt2Fv4c5l7lNy/4uDtz7fFiWZefNwgAitOguUnC9mKXwywEI49fClUmf2ObHYv8qmAppUOTpF+LScHpTJnI5OxJ1eWE3mc79JLrqQbVKHnRMxZZv/Qlm+Z0rLjvMm7pZBGoPgSxSK4azv8khp58zK8gHF6LcW1TBKTPHtKZdQGevkam3NSYdAVPr0T0X4E7ZEE0WFq4DuBwfIxeM6N7lggrJCK1/ObJ4Ns+qc/XxQ==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Christian Lindig <christian.lindig@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 25 Feb 2022 16:34:50 +0000
- Ironport-data: A9a23:6xn8kq5eQNGhloN/x5QzRQxRtC7HchMFZxGqfqrLsTDasY5as4F+v mMcCmCDPaqOZGahedxwad+3900O75HUzIJnTlNory5jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YLjXlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS5cigTb4bjl90naEIFLSIjDZ1ewuDYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsStm9hy3fFCuwhQrjIQrnQ5M8e1zA17ixLNaiBP ZVENWMyBPjGSwcUZ3cxBJVnp6DrmH/kWQMfq3Owi6VitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzRDhgEOfSFxDGC83bqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc9NrPNdrwy6C85DvuFunBTU0fiZ7N8Nz4afaWgcW/ lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/ 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO93ABbvzt68owGOlor+p5 ilsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieRg1a5pZIWexO Cc/XD+9ArcJbRNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WlOniHqdNIdAtSRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WbQelWQhiPsI/SYKs=
- Ironport-hdrordr: A9a23:mHcFG6tHCX3fkh+WO89gp2IH7skC2IMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip 6jlljpx6Z/HFfOmj/w6MPPUAwvnk2ooWA6mepWlHBHV5ACAYUh5rD2bCtuYeY99Q/Bmcka+d NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8 qO
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYKlrZb2DloYmiEUGGLqB4eANGnaykZKqAgAAQIoCAAAGTgA==
- Thread-topic: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
> On 25 Feb 2022, at 16:28, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> On Fri, Feb 25, 2022 at 03:30:59PM +0000, Christian Lindig wrote:
>>
>>
>>> On 25 Feb 2022, at 15:13, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>>>
>>> This patch fix ".ocamldep.make" rule by always spelling the variable
>>> $(OCAML_TOPLEVEL).
>>>
>>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>> ---
>>>
>>> Notes:
>>> v2:
>>> - new patch
>>>
>>> tools/ocaml/libs/eventchn/Makefile | 8 ++++----
>>> tools/ocaml/libs/mmap/Makefile | 8 ++++----
>>> tools/ocaml/libs/xb/Makefile | 8 ++++----
>>> tools/ocaml/libs/xc/Makefile | 8 ++++----
>>> tools/ocaml/libs/xentoollog/Makefile | 8 ++++----
>>> tools/ocaml/libs/xl/Makefile | 8 ++++----
>>> tools/ocaml/libs/xs/Makefile | 8 ++++----
>>> tools/ocaml/Makefile.rules | 2 +-
>>
>> Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
>>
>> I am fine with this but in general think that the OCaml part should be built
>> using Dune (but invoked from Make), which is now the standard tool to build
>> OCaml projects and is simple, fast, and accurate. Edwin maintains such a
>> build for all development work on the OCaml side but it is not upstreamed.
>
> ocaml-dune doesn't seems to be available on debian oldstable. So I don't
> think we can use it for now.
>
> But thanks for pointing that out.
>
I think we should try to add it as an optional build-system: when available use
it, and at some point in the future remove the old one.
It is pretty much impossible to do development on the codebase without it, any
developer who wants to make the changes to the OCaml code will likely want it.
(Of course those who only want to build and install oxenstored may not require
dune, and may be fine with the Makefiles as they wouldn't require incremental
builds or editor support).
Best regards,
--Edwin
> --
> Anthony PERARD
|
