[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
- To: Anthony Perard <anthony.perard@xxxxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Fri, 25 Feb 2022 15:30:59 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A28qk6yx7g9PJoD5im5B7qv5gS2TCCS/6xCmjta4UuU=; b=neO1mTSapynfhEDyeCQyyYoq6CSy4BTz6y0bP+dGCLQp6Io9if76LnX361qGF3GedEVu3m82CIXTeA0S86MHW662Hjs3GMRiklvELZXxBDuulKi+U8CCsQ3+IrTih/MDOuoatZt+y2gLuDZoHSQnfYbNwi2MrPJyyAj5qE7iaheHog3P67+YR9grXX3MyZhcwPf9K/x6HdAApUflXhiJyiaDtC8x35bYpCp/W20Kic/T+ruzEbFDiFx44kJPNArZNgBI/xWdNYZnh6e9FTJsV8etIjsEY3etBoRL24S+c7MsFJnCiQG1YdBqtDWVBlK4j6i40RmbW0eeh24eD1RbKw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aXJ7jbS1eRkaluv0Jf3Irt5o30sQCVAxNP0ecymjj3DRLogBvkYk3j9eu97OTaZYz7RhNn1eJFZiAge9ThSTuTofrf8blOU5zYb3agsh9C4YUHRMWoKpYUY6enNjk6rT3eIsHVbS/MDlxFdQwYMG0hoTBr142Mtfvs9+F5CCgjGpl4VsXcWFQHZZCfEJx9qTfNMFslf4Ll3QtNDc/e3iPWIJAeH+NOre23NVTlB3b5TWRyTUTVYeNHb2AujNyueGQcf0ZA+vHVg5lnZz0Kpe8E73Rnt9a6Tz6vNZnFkcmPMweN6I+BLmR9PapgySPZJ+TGBT/v3FzbSmzoS7RJHF7Q==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>
- Delivery-date: Fri, 25 Feb 2022 15:31:10 +0000
- Ironport-data: A9a23:yUmiO6PbBAbZaYPvrR24l8FynXyQoLVcMsEvi/4bfWQNrUp00mQGn 2tJC2nSOKvcM2L9Kdh2bovl9E5TusDVzIQ2Ggto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFcMpBsJ00o5wbZj2NMw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9 Ipzhbu0TiMTYPPWlfwGUwZRMX0uIvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALJ8nxPZgDu3hmizXYC/onTrjIQrnQ5M8e1zA17ixLNaiCO 5FFN2c+BPjGSwBtZmw8IrIjoPyXgCWjXBRdgnCSv7VitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzRDhgEOfSFxDGC83bqgfXA9QvrVYRXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F qAP0nNw9+5orhXtF4SjGU3jyJKZgvICc+YPLd0d7Aap8PSK+QuBHWgbRxwdOMNz4afaWgcW/ lOOmtroAxlmv7uUVW+R+9+okN+iBcQGBTRcPHFZFGPp9/Gm+dhu1UyXEr6PBYbo1oWdJN3m/ 9ydQMHSbZ03hNVD6ai09Euvb9mE9smQFV5dCuk6swuYAuJFiGyNO93ABbvzt68owGOlor+p5 ilsdy+2tr1mMH11vHbRKNjh5Znwjxp/DBXSgER0A74q/Cm39niocOh4uW8ieRg1a5pZIWexO Cc/XD+9ArcJbRNGioctPuqM5zkCl/C8RbwJqNiOBjaxXnSBXFDep3w/DaJh92vsjFItgckC1 WSzKq6R4YIhIf0/llKeHr5FuZdyn3xW7T6DFPjTkkX8uZLDNSH9dFvwGAbXBgzPxPjf+1u9H hc2H5bi9iizp8WlOniHqdNIdAtSRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WYQelWQhiPsI/SYKs=
- Ironport-hdrordr: A9a23:qaPEtqCbFY5b1ojlHegMsceALOsnbusQ8zAXPh9KJyC9I/b2qy nxppgmPEfP+UossHFJo6HlBEEZKUmsu6KdkrNhQotKOzOW+VdATbsSorcKpgeAJ8SQzJ8k6U 4NSdkdNDS0NykGsS+Y2nj5Lz9D+qj9zEnAv463pB0BLXAIV0gj1XYCNu/yKDwteOAsP+tfKH Po3Ls/m9PWQwVwUi3UPAhhY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJm294ZgC v4uj28wp/mn+Cwyxfa2WOWxY9RgsHdxtxKA9HJotQJKw/rlh2jaO1aKv+/VXEO0aSSAWQR4Z 7xSiQbToJOArTqDziISC7Wqk3dOfAVmiffIBGj8CDeSIfCNUwH4oJ69PNkm13imhcdVZhHod F29nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMEjgC84l/1uwKp5KuZJIMvB0vFtLA CuNrCq2N9GNVeBK3zJtGhmx9KhGnw1AxedW0AH/siYySJfknx1x1YRgJV3pAZNyLstD51fo+ jUOKVhk79DCscQcKJmHe8EBc+6EHbETx7AOH+bZV7nCKYEMXTQrIOf2sR52Mi6PJgTiJcikp XIV11V8WY0ZkL1EMWLmIZG9xjcKV/NFAgFCvsukaSRloeMMYYDaxfzOmzGu/HQ18kiPg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYKlrZb2DloYmiEUGGLqB4eANGnaykZKqA
- Thread-topic: [XEN PATCH v2 29/29] tools/ocaml: fix build dependency target
> On 25 Feb 2022, at 15:13, Anthony PERARD <anthony.perard@xxxxxxxxxx> wrote:
>
> This patch fix ".ocamldep.make" rule by always spelling the variable
> $(OCAML_TOPLEVEL).
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
>
> Notes:
> v2:
> - new patch
>
> tools/ocaml/libs/eventchn/Makefile | 8 ++++----
> tools/ocaml/libs/mmap/Makefile | 8 ++++----
> tools/ocaml/libs/xb/Makefile | 8 ++++----
> tools/ocaml/libs/xc/Makefile | 8 ++++----
> tools/ocaml/libs/xentoollog/Makefile | 8 ++++----
> tools/ocaml/libs/xl/Makefile | 8 ++++----
> tools/ocaml/libs/xs/Makefile | 8 ++++----
> tools/ocaml/Makefile.rules | 2 +-
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
I am fine with this but in general think that the OCaml part should be built
using Dune (but invoked from Make), which is now the standard tool to build
OCaml projects and is simple, fast, and accurate. Edwin maintains such a build
for all development work on the OCaml side but it is not upstreamed.
— C
|
