[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH RFC 3/3] xen: Introduce a platform sub-op to retrieve the VGA information


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 7 Feb 2022 13:44:13 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UgOgIVGHqp6uwlV6qACYzpHBiaLrb2SMnM4IY0n+KVc=; b=YDLvmkR8lRjlMQNoPoF/Ocxq22qmXjXEnuk/MLfOy4chaGoDaRm8QOVRdd1eK9AeWdpHSYYPr8AMuG1tbSLduB8d5KLvxYyIpk9l+0ipo93vBmUTjPh0WxHspUAKOWP7HPBWOS43CynRVgpoy+DUn6WLGw5ZLs3hlPGoHkEdyR5Yr/bLiCW0zFREBYYtvV+V4k60gded8heiQtsVPQoSeLl1hBG/4uJFj7gw1xcRolLvIXBM6pA7Xnrh7KxmI0URo0aRY3Xn0BVw87nHdpGzJoTxy2Aef6BHpbStfNjatw0qzfHK1aTnA1KepoCLPbATUi99zY/tLOCYgAP/qBpGvA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lmWQeIFfiKL0YuATWWkOVdSk0PGOgb2grDq1nEPD9gJmZo3mBn8WQWAs3A9wuGOftykAA+ZdwCG0FWKoLZs3yNdeA5AKRhvYC6jZHlORPOGV0TVKBuoEg8RhXGmonQDN+OPLfOfiaUxBoHwOvKx+1QTOmeTUuV0qni5p0sRlXatUW5UTf+/DHJAh0aZZyEWCsNITuhwawf2NPjT5K7jl5j3ZJdNoqkRR+kF+vFi3LdxYUi7mGhm/Znxq8lt5Xno9Pk3iZpfK+4EddF0dnVYBx/7DUlCeTe3S0bxAyTHW0WndZJE/HWsCnPsiR0TikIKuGH0Baot2khGbuaFJehlTIg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: ehem+xen@xxxxxxx, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Mon, 07 Feb 2022 12:44:21 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 07.02.2022 12:58, Roger Pau Monné wrote:
> On Mon, Feb 07, 2022 at 09:57:55AM +0100, Jan Beulich wrote:
>> On 06.02.2022 20:28, Julien Grall wrote:
>>> @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
>>>  
>>>          /* Int16, Fn02: Get keyboard shift flags. */
>>>          uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
>>> +        struct dom0_vga_console_info vga;
>>
>> ... the structure name including "vga" (but if the #define is adjusted,
>> the field name would want to become "video" as well).
> 
> It's my understanding that this will forcefully be
> XEN_VGATYPE_EFI_LFB, at which point we could consider giving a type
> name to the vesa_lfb field of dom0_vga_console_info (video_lfb) and
> use the same struct here?
> 
> There's no need to propagate XEN_VGATYPE_TEXT_MODE_3 into this
> interface.

Hmm, yes, this is probably better / more clean. Julien, thoughts?

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.